Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1670243002: Add command line options (Closed)

Created:
4 years, 10 months ago by siva
Modified:
4 years, 10 months ago
Reviewers:
rmacnak, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add command line options - full-snapshot-after-run (This option generates a full snapshot of an application after it is run with some sample input scenarios, this snapshot includes all the core libraries and other framework libraries and could be potentially tree-shaken to reduce the size) - run-full-snapshot (This option reads a full snapshot that was generated using the option above and runs it) Example: First generate the full application snapshot: dart_no_snapshot --full-snapshot-after-run=script --package-root=..../packages/ ..../lib/_internal/compiler/implementation/dart2js.dart --categories=all ..../dummy_compiler_test.dart Then run the full application snapshot generated above: dart --run-full-snapshot=script ..../lib/_internal/compiler/implementation/dart2js.dart --categories=all ..../dummy_compiler_test.dart R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/62b12f27d64ea790adea71a49584f14528a96175

Patch Set 1 #

Patch Set 2 : self-review-comments #

Total comments: 4

Patch Set 3 : code-review-changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -115 lines) Patch
M runtime/bin/main.cc View 1 2 29 chunks +222 lines, -115 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
4 years, 10 months ago (2016-02-05 17:25:35 UTC) #2
srdjan
LGTM. Can the instructions for running --full_snapshot_after_run be saved as comment in main.cc? https://codereview.chromium.org/1670243002/diff/20001/runtime/bin/main.cc File ...
4 years, 10 months ago (2016-02-05 17:35:02 UTC) #3
siva
https://codereview.chromium.org/1670243002/diff/20001/runtime/bin/main.cc File runtime/bin/main.cc (right): https://codereview.chromium.org/1670243002/diff/20001/runtime/bin/main.cc#newcode84 runtime/bin/main.cc:84: static bool noopt = false; On 2016/02/05 17:35:02, srdjan ...
4 years, 10 months ago (2016-02-05 23:14:18 UTC) #4
siva
4 years, 10 months ago (2016-02-05 23:29:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
62b12f27d64ea790adea71a49584f14528a96175 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698