third_party/WebKit/Source/core/loader/FrameLoader.cpp - Issue 1670173002: Don't set the origin twice when navigating for javascript: URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 1670173002: Don't set the origin twice when navigating for javascript: URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: steal dcheng's tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

index d9ff10255d983a431a82f8c790bd8bc9eefa8e78..4e860f176ad3d792af0347de97257a1a452a85b4 100644

--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp

@@ -327,6 +327,7 @@ void FrameLoader::replaceDocumentWhileExecutingJavaScriptURL(const String& sourc

// inherit an aliased security context.

DocumentInit init(m_frame->document()->url(), m_frame);

init.withNewRegistrationContext();

+ init.withoutInheritingSecurityOrigin();

stopAllLoaders();

// Don't allow any new child frames to load in this frame: attaching a new

« third_party/WebKit/Source/core/dom/DocumentInit.cpp ('K') | « third_party/WebKit/Source/core/dom/DocumentInit.cpp ('k') | no next file » | no next file with comments »