Create image cache for use by json canvas

Create image cache for use by json canvas

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1670153005

Committed: https://skia.googlesource.com/skia/+/cdad12f3b14e7cb4c1aa03990ea8044a3f204403

[joshua.litt, 2016-02-05 19:53:45]

Description was changed from

==========
Create image cache for use by json canvas

BUG=skia:
==========

to

==========
Create image cache for use by json canvas

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[joshualitt, 2016-02-05 19:59:24]

joshualitt@google.com changed reviewers:
+ ethannicholas@google.com, jcgregorio@google.com, joshualitt@google.com

[joshualitt, 2016-02-05 19:59:24]

ptal

[ethannicholas, 2016-02-08 14:26:35]

https://codereview.chromium.org/1670153005/diff/80001/tools/UrlDataManager.h
File tools/UrlDataManager.h (right):

https://codereview.chromium.org/1670153005/diff/80001/tools/UrlDataManager.h#...
tools/UrlDataManager.h:27: SkString addData(SkData*, const char* contentType);
Can we get some documentation on this method, e.g. clarify that calling it twice
with two identical SkDatas results in the same URL?

[joshualitt, 2016-02-08 14:36:08]

On 2016/02/08 14:26:35, ethannicholas wrote:
> https://codereview.chromium.org/1670153005/diff/80001/tools/UrlDataManager.h
> File tools/UrlDataManager.h (right):
> 
>
https://codereview.chromium.org/1670153005/diff/80001/tools/UrlDataManager.h#...
> tools/UrlDataManager.h:27: SkString addData(SkData*, const char* contentType);
> Can we get some documentation on this method, e.g. clarify that calling it
twice
> with two identical SkDatas results in the same URL?

done

[ethannicholas, 2016-02-08 14:43:27]

On 2016/02/08 14:36:08, joshualitt wrote:
> On 2016/02/08 14:26:35, ethannicholas wrote:
> > https://codereview.chromium.org/1670153005/diff/80001/tools/UrlDataManager.h
> > File tools/UrlDataManager.h (right):
> > 
> >
>
https://codereview.chromium.org/1670153005/diff/80001/tools/UrlDataManager.h#...
> > tools/UrlDataManager.h:27: SkString addData(SkData*, const char*
contentType);
> > Can we get some documentation on this method, e.g. clarify that calling it
> twice
> > with two identical SkDatas results in the same URL?
> 
> done

lgtm

[joshualitt, 2016-02-08 14:45:22]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2016-02-08 14:45:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670153005/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670153005/100001

[commit-bot: I haz the power, 2016-02-08 15:08:23]

Description was changed from

==========
Create image cache for use by json canvas

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Create image cache for use by json canvas

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/cdad12f3b14e7cb4c1aa03990ea8044a3f204403
==========

[commit-bot: I haz the power, 2016-02-08 15:08:24]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/cdad12f3b14e7cb4c1aa03990ea8044a3f204403