Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1670153004: Move RenderWidgetTest to the one file in which it's used. (Closed)

Created:
4 years, 10 months ago by Avi (use Gerrit)
Modified:
4 years, 10 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move RenderWidgetTest to the one file in which it's used. BUG=583347 TEST=all green Committed: https://crrev.com/72fc4b00f6429a70e1c841a9678af04580ce1efd Cr-Commit-Position: refs/heads/master@{#374015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -82 lines) Patch
M content/content_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D content/public/test/render_widget_test.h View 1 chunk +0 lines, -45 lines 0 comments Download
D content/public/test/render_widget_test.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M content/renderer/render_widget_browsertest.cc View 1 chunk +17 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670153004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670153004/1
4 years, 10 months ago (2016-02-05 17:14:53 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-05 18:27:33 UTC) #4
Avi (use Gerrit)
4 years, 10 months ago (2016-02-05 19:16:01 UTC) #6
ncarter (slow)
lgtm
4 years, 10 months ago (2016-02-05 22:10:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670153004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670153004/1
4 years, 10 months ago (2016-02-06 07:06:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-06 07:10:05 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-06 07:11:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72fc4b00f6429a70e1c841a9678af04580ce1efd
Cr-Commit-Position: refs/heads/master@{#374015}

Powered by Google App Engine
This is Rietveld 408576698