Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 1670153002: Fix Array.prototype.sort for *_STRING_WRAPPER_ELEMENTS (Closed)

Created:
4 years, 10 months ago by Jakob Kummerow
Modified:
4 years, 10 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Array.prototype.sort for *_STRING_WRAPPER_ELEMENTS Trying to sort a string should throw a TypeError, proper handling of elements just needs to get out of the way. BUG=chromium:584188 LOG=n R=cbruni@chromium.org Committed: https://crrev.com/5d2c09a8296d22971fc37696bdf2815f3aacf393 Cr-Commit-Position: refs/heads/master@{#33777}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M src/objects.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime/runtime-array.cc View 2 chunks +10 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-584188.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
4 years, 10 months ago (2016-02-05 12:56:40 UTC) #1
Camillo Bruni
lgtm
4 years, 10 months ago (2016-02-05 13:10:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670153002/1
4 years, 10 months ago (2016-02-05 13:10:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 13:36:39 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 13:37:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d2c09a8296d22971fc37696bdf2815f3aacf393
Cr-Commit-Position: refs/heads/master@{#33777}

Powered by Google App Engine
This is Rietveld 408576698