Visit the Optimized Code Map on first call rather than closure creation.

test/cctest/heap/test-heap.cc

Index: test/cctest/heap/test-heap.cc
diff --git a/test/cctest/heap/test-heap.cc b/test/cctest/heap/test-heap.cc
index 1ba0f5006a5a7257810ab2472a4939067aa52c22..dcf9941c62e1611fbba5f2f4b89ca123e4268f92 100644
--- a/test/cctest/heap/test-heap.cc
+++ b/test/cctest/heap/test-heap.cc
@@ -1517,6 +1517,9 @@ TEST(TestCodeFlushingIncrementalAbort) {
 }
 
 TEST(TestUseOfIncrementalBarrierOnCompileLazy) {
+  // This test requires us to run the CompileLazy builtin, which won't be run
+  // when the interpreter is used.
+  if (i::FLAG_ignition) return;

[Michael Starzinger, 2016/04/08 12:44:02]

This should actually only happen because of eager compilation with Ignition. Can
we change this to "i::FLAG_ignition_eager = false" here? If that doesn't work,
then I would vote for marking the test as FAIL for Ignition in the status file,
because I think this is something we would need to investigate then.

[Michael Starzinger, 2016/04/08 12:53:05]

Actually, as discussed offline: This should even work with eager compilation,
because the closure should still be initialized to the CompileLazy builtin, even
if the shared function info is already compiled. So better check if this is
still needed at all. If it is, then we should mark it as FAIL for Ignitition
instead.

[mvstanton, 2016/04/11 13:36:14]

Yes, it still fails with --turbo and --ignition. I created a bug, initially
assigned to me (but I'll give it to you or Ross most likely) and added a TODO in
the status file.

[mvstanton, 2016/04/11 13:36:14]

Acknowledged.

   // Turn off always_opt because it interferes with running the built-in for
   // the last call to g().
   i::FLAG_always_opt = false;
@@ -1546,10 +1549,7 @@ TEST(TestUseOfIncrementalBarrierOnCompileLazy) {
   Handle<Object> g_value =
       Object::GetProperty(isolate->global_object(), g_name).ToHandleChecked();
   Handle<JSFunction> g_function = Handle<JSFunction>::cast(g_value);
-  // TODO(mvstanton): change to check that g is *not* compiled when optimized
-  // cache
-  // map lookup moves to the compile lazy builtin.
-  CHECK(g_function->is_compiled());
+  CHECK(!g_function->is_compiled());
 
   SimulateIncrementalMarking(heap);
   CompileRun("%OptimizeFunctionOnNextCall(f); f();");