Visit the Optimized Code Map on first call rather than closure creation.

src/compiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler.h"
 
 #include <algorithm>
 
 #include "src/ast/ast-numbering.h"
 #include "src/ast/prettyprinter.h"
@@ skipping 1061 matching lines @@
   return MaybeHandle<Code>();
 }
 
 MaybeHandle<Code> GetLazyCode(Handle<JSFunction> function) {
   Isolate* isolate = function->GetIsolate();
   DCHECK(!isolate->has_pending_exception());
   DCHECK(!function->is_compiled());
   TimerEventScope<TimerEventCompileCode> compile_timer(isolate);
   TRACE_EVENT0("v8", "V8.CompileCode");
   AggregatedHistogramTimerScope timer(isolate->counters()->compile_lazy());
+
+  if (FLAG_turbo_cache_shared_code) {
+    SharedFunctionInfo* shared = function->shared();
+    CodeAndLiterals result;
+    result = shared->SearchOptimizedCodeMap(

[Michael Starzinger, 2016/04/08 12:44:02]

nit: Just use "function->shared()" directly here, raw pointer is scary.

[mvstanton, 2016/04/11 13:36:14]

Done.

+        *function->GetIsolate()->native_context(), BailoutId::None());

[Michael Starzinger, 2016/04/08 12:44:02]

nit: The "isolate" variable is available, let's use it for readability.

[mvstanton, 2016/04/11 13:36:14]

Done.

+    if (result.code != nullptr) {
+      return Handle<Code>(result.code);
+    }
+  }
+
   // If the debugger is active, do not compile with turbofan unless we can
   // deopt from turbofan code.
   if (FLAG_turbo_asm && function->shared()->asm_function() &&
       (FLAG_turbo_asm_deoptimization || !isolate->debug()->is_active()) &&
       !FLAG_turbo_osr) {
     Handle<Code> code;
     if (GetOptimizedCode(function, Compiler::NOT_CONCURRENT).ToHandle(&code)) {
       DCHECK(function->shared()->is_compiled());
       return code;
     }
@@ skipping 216 matching lines @@
   return true;
 }
 
 bool Compiler::ParseAndAnalyze(ParseInfo* info) {
   if (!Parser::ParseStatic(info)) return false;
   return Compiler::Analyze(info);
 }
 
 bool Compiler::Compile(Handle<JSFunction> function, ClearExceptionFlag flag) {
   if (function->is_compiled()) return true;
+
   MaybeHandle<Code> maybe_code = GetLazyCode(function);
   Handle<Code> code;
   if (!maybe_code.ToHandle(&code)) {
     if (flag == CLEAR_EXCEPTION) {
       function->GetIsolate()->clear_pending_exception();
     }
     return false;
   }
   DCHECK(code->IsJavaScriptCode());
   function->ReplaceCode(*code);
@@ skipping 570 matching lines @@
     MaybeHandle<Code> code;
     if (cached.code != nullptr) code = handle(cached.code);
     Handle<Context> native_context(function->context()->native_context());
     SharedFunctionInfo::AddToOptimizedCodeMap(shared, native_context, code,
                                               literals, BailoutId::None());
   }
 }
 
 }  // namespace internal
 }  // namespace v8