Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Side by Side Diff: src/x64/builtins-x64.cc

Issue 1670143002: Visit the Optimized Code Map on first call rather than closure creation. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Removed overly-restrictive assert. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects-inl.h ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 886 matching lines...) Expand 10 before | Expand all | Expand 10 after
897 // This simulates the initial call to bytecode handlers in interpreter entry 897 // This simulates the initial call to bytecode handlers in interpreter entry
898 // trampoline. The return will never actually be taken, but our stack walker 898 // trampoline. The return will never actually be taken, but our stack walker
899 // uses this address to determine whether a frame is interpreted. 899 // uses this address to determine whether a frame is interpreted.
900 __ Push(masm->isolate()->builtins()->InterpreterEntryTrampoline()); 900 __ Push(masm->isolate()->builtins()->InterpreterEntryTrampoline());
901 901
902 Generate_EnterBytecodeDispatch(masm); 902 Generate_EnterBytecodeDispatch(masm);
903 } 903 }
904 904
905 905
906 void Builtins::Generate_CompileLazy(MacroAssembler* masm) { 906 void Builtins::Generate_CompileLazy(MacroAssembler* masm) {
907 // ----------- S t a t e -------------
908 // -- rax : argument count (preserved for callee)
909 // -- rdx : new target (preserved for callee)
910 // -- rdi : target function (preserved for callee)
911 // -----------------------------------
912 // First lookup code, maybe we don't need to compile!
913 Label gotta_call_runtime;
914 Label maybe_call_runtime;
915 Label try_shared;
916 Label loop_top, loop_bottom;
917
918 Register closure = rdi;
919 Register map = r8;
920 Register index = r9;
921 __ movp(map, FieldOperand(closure, JSFunction::kSharedFunctionInfoOffset));
922 __ movp(map, FieldOperand(map, SharedFunctionInfo::kOptimizedCodeMapOffset));
923 __ SmiToInteger32(index, FieldOperand(map, FixedArray::kLengthOffset));
924 __ cmpl(index, Immediate(2));
925 __ j(less, &gotta_call_runtime);
926
927 // Find literals.
928 // r14 : native context
929 // r9 : length / index
930 // r8 : optimized code map
931 // rdx : new target
932 // rdi : closure
933 Register native_context = r14;
934 __ movp(native_context, NativeContextOperand());
935
936 __ bind(&loop_top);
937 // Native context match?
938 Register temp = r11;
939 __ movp(temp, FieldOperand(map, index, times_pointer_size,
940 SharedFunctionInfo::kOffsetToPreviousContext));
941 __ movp(temp, FieldOperand(temp, WeakCell::kValueOffset));
942 __ cmpp(temp, native_context);
943 __ j(not_equal, &loop_bottom);
944 // OSR id set to none?
945 __ movp(temp, FieldOperand(map, index, times_pointer_size,
946 SharedFunctionInfo::kOffsetToPreviousOsrAstId));
947 __ SmiToInteger32(temp, temp);
948 const int bailout_id = BailoutId::None().ToInt();
949 __ cmpl(temp, Immediate(bailout_id));
950 __ j(not_equal, &loop_bottom);
951 // Literals available?
952 __ movp(temp, FieldOperand(map, index, times_pointer_size,
953 SharedFunctionInfo::kOffsetToPreviousLiterals));
954 __ movp(temp, FieldOperand(temp, WeakCell::kValueOffset));
955 __ JumpIfSmi(temp, &gotta_call_runtime);
956
957 // Save the literals in the closure.
958 __ movp(FieldOperand(closure, JSFunction::kLiteralsOffset), temp);
959 __ movp(r15, index);
960 __ RecordWriteField(closure, JSFunction::kLiteralsOffset, temp, r15,
961 kDontSaveFPRegs, EMIT_REMEMBERED_SET, OMIT_SMI_CHECK);
962
963 // Code available?
964 Register entry = rcx;
965 __ movp(entry, FieldOperand(map, index, times_pointer_size,
966 SharedFunctionInfo::kOffsetToPreviousCachedCode));
967 __ movp(entry, FieldOperand(entry, WeakCell::kValueOffset));
968 __ JumpIfSmi(entry, &maybe_call_runtime);
969
970 // Found literals and code. Get them into the closure and return.
971 __ leap(entry, FieldOperand(entry, Code::kHeaderSize));
972
973 Label install_optimized_code_and_tailcall;
974 __ bind(&install_optimized_code_and_tailcall);
975 __ movp(FieldOperand(closure, JSFunction::kCodeEntryOffset), entry);
976 __ RecordWriteCodeEntryField(closure, entry, r15);
977
978 // Link the closure into the optimized function list.
979 // rcx : code entry (entry)
980 // r14 : native context
981 // rdx : new target
982 // rdi : closure
983 __ movp(rbx,
984 ContextOperand(native_context, Context::OPTIMIZED_FUNCTIONS_LIST));
985 __ movp(FieldOperand(closure, JSFunction::kNextFunctionLinkOffset), rbx);
986 __ RecordWriteField(closure, JSFunction::kNextFunctionLinkOffset, rbx, r15,
987 kDontSaveFPRegs, EMIT_REMEMBERED_SET, OMIT_SMI_CHECK);
988 const int function_list_offset =
989 Context::SlotOffset(Context::OPTIMIZED_FUNCTIONS_LIST);
990 __ movp(ContextOperand(native_context, Context::OPTIMIZED_FUNCTIONS_LIST),
991 closure);
992 // Save closure before the write barrier.
993 __ movp(rbx, closure);
994 __ RecordWriteContextSlot(native_context, function_list_offset, closure, r15,
995 kDontSaveFPRegs);
996 __ movp(closure, rbx);
997 __ jmp(entry);
998
999 __ bind(&loop_bottom);
1000 __ subl(index, Immediate(SharedFunctionInfo::kEntryLength));
1001 __ cmpl(index, Immediate(1));
1002 __ j(greater, &loop_top);
1003
1004 // We found neither literals nor code.
1005 __ jmp(&gotta_call_runtime);
1006
1007 __ bind(&maybe_call_runtime);
1008
1009 // Last possibility. Check the context free optimized code map entry.
1010 __ movp(entry, FieldOperand(map, FixedArray::kHeaderSize +
1011 SharedFunctionInfo::kSharedCodeIndex));
1012 __ movp(entry, FieldOperand(entry, WeakCell::kValueOffset));
1013 __ JumpIfSmi(entry, &try_shared);
1014
1015 // Store code entry in the closure.
1016 __ leap(entry, FieldOperand(entry, Code::kHeaderSize));
1017 __ jmp(&install_optimized_code_and_tailcall);
1018
1019 __ bind(&try_shared);
1020 // Is the full code valid?
1021 __ movp(entry, FieldOperand(closure, JSFunction::kSharedFunctionInfoOffset));
1022 __ movp(entry, FieldOperand(entry, SharedFunctionInfo::kCodeOffset));
1023 __ movl(rbx, FieldOperand(entry, Code::kFlagsOffset));
1024 __ andl(rbx, Immediate(Code::KindField::kMask));
1025 __ shrl(rbx, Immediate(Code::KindField::kShift));
1026 __ cmpl(rbx, Immediate(Code::BUILTIN));
1027 __ j(equal, &gotta_call_runtime);
1028 // Yes, install the full code.
1029 __ leap(entry, FieldOperand(entry, Code::kHeaderSize));
1030 __ movp(FieldOperand(closure, JSFunction::kCodeEntryOffset), entry);
1031 __ RecordWriteCodeEntryField(closure, entry, r15);
1032 __ jmp(entry);
1033
1034 __ bind(&gotta_call_runtime);
907 GenerateTailCallToReturnedCode(masm, Runtime::kCompileLazy); 1035 GenerateTailCallToReturnedCode(masm, Runtime::kCompileLazy);
908 } 1036 }
909 1037
910 1038
911 void Builtins::Generate_CompileOptimized(MacroAssembler* masm) { 1039 void Builtins::Generate_CompileOptimized(MacroAssembler* masm) {
912 GenerateTailCallToReturnedCode(masm, 1040 GenerateTailCallToReturnedCode(masm,
913 Runtime::kCompileOptimized_NotConcurrent); 1041 Runtime::kCompileOptimized_NotConcurrent);
914 } 1042 }
915 1043
916 1044
(...skipping 1874 matching lines...) Expand 10 before | Expand all | Expand 10 after
2791 __ ret(0); 2919 __ ret(0);
2792 } 2920 }
2793 2921
2794 2922
2795 #undef __ 2923 #undef __
2796 2924
2797 } // namespace internal 2925 } // namespace internal
2798 } // namespace v8 2926 } // namespace v8
2799 2927
2800 #endif // V8_TARGET_ARCH_X64 2928 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/objects-inl.h ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698