Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 1670133002: [es6] Further fixing of tail Calls. (Closed)

Created:
4 years, 10 months ago by Igor Sheludko
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] Further fixing of tail Calls. 1) Update profiling counters in Full codegen. 2) Call Runtime::kTraceTailCall when tracing is on test/mjsunit/es6/tail-call-simple.js is disabled for now, because Turbofan does not fully support TCO yet. BUG=v8:4698 LOG=N Committed: https://crrev.com/e519e6fadfaf7242231f4dcb45910f60304e26fc Cr-Commit-Position: refs/heads/master@{#33886}

Patch Set 1 : #

Patch Set 2 : Rebasing and other ports #

Patch Set 3 : Revert crankshaft changes #

Patch Set 4 : Tail call tracing added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -146 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 3 3 chunks +33 lines, -18 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 3 3 chunks +33 lines, -19 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 3 3 chunks +33 lines, -18 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 3 3 chunks +33 lines, -18 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 3 3 chunks +33 lines, -18 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 3 3 chunks +33 lines, -18 lines 0 comments Download
M src/runtime/runtime.h View 1 2 3 3 chunks +1 line, -2 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 2 3 1 chunk +25 lines, -24 lines 0 comments Download
M test/mjsunit/es6/tail-call-simple.js View 1 5 chunks +24 lines, -7 lines 0 comments Download
M test/mjsunit/function-caller.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/strict-mode.js View 1 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 36 (20 generated)
Igor Sheludko
PTAL x64
4 years, 10 months ago (2016-02-05 13:14:07 UTC) #5
Benedikt Meurer
LGTM modulo port.
4 years, 10 months ago (2016-02-05 13:40:51 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670133002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670133002/60001
4 years, 10 months ago (2016-02-08 17:26:41 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13453)
4 years, 10 months ago (2016-02-08 17:40:31 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670133002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670133002/80001
4 years, 10 months ago (2016-02-08 17:57:04 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-08 18:21:36 UTC) #19
Igor Sheludko
PTAL with all the ports
4 years, 10 months ago (2016-02-10 07:50:37 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670133002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670133002/120001
4 years, 10 months ago (2016-02-11 09:00:36 UTC) #24
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-11 09:21:22 UTC) #26
Igor Sheludko
PTAL, I removed crankshaft related changes and added Runtime_TraceTailCall.
4 years, 10 months ago (2016-02-11 09:24:45 UTC) #27
Benedikt Meurer
lgtm
4 years, 10 months ago (2016-02-11 09:56:45 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670133002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670133002/120001
4 years, 10 months ago (2016-02-11 10:25:32 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1670133002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1670133002/120001
4 years, 10 months ago (2016-02-11 10:25:36 UTC) #31
commit-bot: I haz the power
Committed patchset #4 (id:120001)
4 years, 10 months ago (2016-02-11 10:26:48 UTC) #33
commit-bot: I haz the power
Committed patchset #4 (id:120001)
4 years, 10 months ago (2016-02-11 10:26:54 UTC) #34
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 10:41:19 UTC) #36
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e519e6fadfaf7242231f4dcb45910f60304e26fc
Cr-Commit-Position: refs/heads/master@{#33886}

Powered by Google App Engine
This is Rietveld 408576698