Issue 167013002: Port SiblingTraversalStrategies to ElementTraversal API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 167013002: Port SiblingTraversalStrategies to ElementTraversal API (Closed)

Created:
6 years, 10 months ago by Inactive

Modified:
6 years, 10 months ago

Reviewers:
adamk, eseidel

CC:
blink-reviews, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, Inactive, rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Port SiblingTraversalStrategies to ElementTraversal API Port SiblingTraversalStrategies to ElementTraversal API for consistency. Node's previousElementSibling() / nextElementSibling() will be wrappers around ElementTraversal soon. Also pass the element by reference instead of pointer in SiblingTraversalStrategies's API to make the code cleaner. R=adamk, eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167223

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -53 lines)			Patch
M	Source/core/css/SelectorChecker.cpp	View	8 chunks	+11 lines, -11 lines	0 comments	Download
M	Source/core/css/SiblingTraversalStrategies.h	View	10 chunks	+42 lines, -41 lines	0 comments	Download
M	Source/core/dom/ElementTraversal.h	View	2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

adamk

lgtm Looks like this is going to fight with your other change, so I'll let ...

6 years, 10 months ago (2014-02-14 17:49:35 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/167013002/1

6 years, 10 months ago (2014-02-14 18:19:23 UTC) #4

Message was sent while issue was closed.

Change committed as 167223

Expand Messages | Collapse Messages