Issue 1670113004: VM: Optimized calls to asin, acos, tan.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1670113004: VM: Optimized calls to asin, acos, tan. (Closed)

Created:
4 years, 10 months ago by Florian Schneider

Modified:
4 years, 10 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Optimized calls to asin, acos, tan. Reorganize a long chain of if-else-if into a switch. BUG= R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/4ab3a12a0c9d8fb8ab026aa1b9b345ffcf6a67aa

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+182 lines, -132 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+143 lines, -120 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	4 chunks	+33 lines, -12 lines	0 comments	Download
M	runtime/vm/method_recognizer.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/runtime_entry_list.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

4 years, 10 months ago (2016-02-08 13:21:58 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4ab3a12a0c9d8fb8ab026aa1b9b345ffcf6a67aa (presubmit successful).