Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 16701004: Fix webkit_storage exports definitions (Closed)

Created:
7 years, 6 months ago by kinuko
Modified:
7 years, 6 months ago
Reviewers:
michaeln, tzik
CC:
chromium-reviews, michaeln, tzik+watch_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org
Visibility:
Public.

Description

Fix webkit_storage exports definitions Also removes webkit/storage/* BUG=239109 R=tzik@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205996

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -364 lines) Patch
M webkit/browser/appcache/appcache.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/browser/appcache/appcache_backend_impl.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/appcache/appcache_database.h View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M webkit/browser/appcache/appcache_disk_cache.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/appcache/appcache_group.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/appcache/appcache_host.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/appcache/appcache_interceptor.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/appcache/appcache_quota_client.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M webkit/browser/appcache/appcache_request_handler.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/appcache/appcache_response.h View 1 2 7 chunks +9 lines, -7 lines 0 comments Download
M webkit/browser/appcache/appcache_service.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/appcache/appcache_storage.h View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M webkit/browser/appcache/appcache_storage_impl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/appcache/appcache_update_job.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/appcache/appcache_url_request_job.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/appcache/appcache_working_set.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/appcache/manifest_parser.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/appcache/view_appcache_internals_job.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/blob/blob_data_handle.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/blob/blob_storage_context.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/blob/blob_storage_controller.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/blob/blob_storage_host.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/blob/blob_url_request_job.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/browser/blob/blob_url_request_job_factory.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/blob/file_stream_reader.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/blob/local_file_stream_reader.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/browser/blob/view_blob_internals_job.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/chromeos/fileapi/cros_mount_point_provider.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/chromeos/fileapi/file_access_permissions.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/database/database_quota_client.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/database/database_tracker.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/browser/database/database_util.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/database/databases_table.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/database/vfs_backend.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_area.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_context.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_database.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_database_adapter.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_host.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_namespace.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_session.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/dom_storage/dom_storage_task_runner.h View 1 2 4 chunks +5 lines, -4 lines 0 comments Download
M webkit/browser/dom_storage/local_storage_database_adapter.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/dom_storage/session_storage_database.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/async_file_util.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/async_file_util_adapter.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/copy_or_move_file_validator.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/external_mount_points.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/file_observers.h View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/file_permission_policy.h View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
M webkit/browser/fileapi/file_stream_writer.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_context.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_dir_url_request_job.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_file_stream_reader.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_file_util.h View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/file_system_mount_point_provider.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_context.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_operation_runner.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_options.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_quota_client.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_quota_util.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_task_runners.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_url.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_url_request_job_factory.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_system_usage_cache.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/file_writer_delegate.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/isolated_context.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/isolated_file_util.h View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/local_file_stream_writer.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/local_file_system_operation.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/local_file_util.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/mount_points.h View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/native_file_util.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/obfuscated_file_util.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_directory_database.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/sandbox_file_stream_writer.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_isolated_origin_database.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_mount_point_provider.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/sandbox_origin_database.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/fileapi/sandbox_origin_database_interface.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/syncable/file_change.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/syncable/local_file_change_tracker.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/syncable/local_file_sync_context.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/syncable/local_file_sync_status.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/syncable/sync_file_metadata.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/fileapi/syncable/sync_status_code.h View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M webkit/browser/fileapi/syncable/syncable_file_operation_runner.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/syncable/syncable_file_system_operation.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/syncable/syncable_file_system_util.h View 1 2 6 chunks +13 lines, -11 lines 0 comments Download
M webkit/browser/fileapi/test_mount_point_provider.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/timed_task_helper.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/transient_file_util.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/browser/fileapi/upload_file_system_file_element_reader.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/quota/quota_client.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/quota/quota_database.h View 1 2 5 chunks +6 lines, -6 lines 0 comments Download
M webkit/browser/quota/quota_manager.h View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M webkit/browser/quota/quota_task.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/quota/quota_temporary_storage_evictor.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/browser/quota/special_storage_policy.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/browser/quota/usage_tracker.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
A webkit/browser/webkit_storage_browser_export.h View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
M webkit/common/appcache/appcache_interfaces.h View 1 2 7 chunks +16 lines, -16 lines 0 comments Download
M webkit/common/blob/blob_data.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/common/blob/scoped_file.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/common/blob/shareable_file_reference.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/database/database_connections.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/common/dom_storage/dom_storage_map.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/common/dom_storage/dom_storage_types.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/common/fileapi/file_system_util.h View 1 2 5 chunks +27 lines, -25 lines 0 comments Download
M webkit/common/quota/quota_status_code.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A webkit/common/webkit_storage_common_export.h View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M webkit/renderer/appcache/appcache_frontend_impl.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/renderer/appcache/web_application_cache_host_impl.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/renderer/dom_storage/dom_storage_cached_area.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/renderer/fileapi/webfilewriter_base.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A webkit/renderer/webkit_storage_renderer_export.h View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M webkit/renderer/webpreferences_renderer.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
D webkit/storage/webkit_storage_export.h View 1 chunk +0 lines, -34 lines 0 comments Download
M webkit/storage_browser.gyp View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
M webkit/storage_common.gyp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/storage_renderer.gyp View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kinuko
PTL
7 years, 6 months ago (2013-06-12 05:33:35 UTC) #1
kinuko
Hmm... will change them to WEBKIT_STORAGE_{BROWSER,RENDERER,COMMON} to make sure.
7 years, 6 months ago (2013-06-12 05:38:24 UTC) #2
kinuko
Updated. PTAL
7 years, 6 months ago (2013-06-12 07:20:19 UTC) #3
tzik
lgtm
7 years, 6 months ago (2013-06-12 08:04:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/16701004/31001
7 years, 6 months ago (2013-06-12 16:41:45 UTC) #5
commit-bot: I haz the power
Failed to apply patch for webkit/browser/fileapi/sandbox_file_stream_writer.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-12 17:58:25 UTC) #6
kinuko
7 years, 6 months ago (2013-06-13 02:59:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 manually as r205996.

Powered by Google App Engine
This is Rietveld 408576698