extend modecolorfilter to 4f

extend modecolorfilter to 4f

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1670063002

Committed: https://skia.googlesource.com/skia/+/3125565804054691b110b4731bc5a32070fab780

[reed1, 2016-02-05 04:35:08]

Description was changed from

==========
extend modecolorfilter to 4f

BUG=skia:
==========

to

==========
extend modecolorfilter to 4f

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[reed1, 2016-02-05 20:37:42]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-05 20:37:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670063002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670063002/20001

[commit-bot: I haz the power, 2016-02-05 21:09:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 21:09:52]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-02-05 21:14:10]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-05 21:14:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670063002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670063002/40001

[reed1, 2016-02-05 21:33:02]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-05 21:33:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670063002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670063002/60001

[reed1, 2016-02-05 21:33:30]

reed@google.com changed reviewers:
+ herb@google.com, mtklein@google.com

[reed1, 2016-02-05 21:33:31]

ptal

[commit-bot: I haz the power, 2016-02-05 22:37:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 22:37:10]

Dry run: This issue passed the CQ dry run.

[reed1, 2016-02-08 13:43:22]

reed@google.com changed reviewers:
+ fmalita@chromium.org

[reed1, 2016-02-08 17:24:02]

any comments?

[mtklein, 2016-02-08 18:27:22]

https://codereview.chromium.org/1670063002/diff/60001/src/core/SkXfermode.cpp
File src/core/SkXfermode.cpp (right):

https://codereview.chromium.org/1670063002/diff/60001/src/core/SkXfermode.cpp...
src/core/SkXfermode.cpp:102: static SkPM4f srcover_proc4f(const SkPM4f& src,
const SkPM4f& dst) {
Maybe we can make these easier to read with some little wrappers?

E.g.

template <Sk4f (*Proc)(const Sk4f&, const Sk4f&)>
SkPM4f proc_4f(const SkPM4f& src, const SkPM4f& dst) {
   return as_pm4f(Proc(as_4f(src), as_4f(dst));
}

static Sk4f alpha(const Sk4f& x) {
   return Sk4f(x.kth<SkPM4f::A>());
}

then write all these as

static Sk4f srcover_4f(const Sk4f& src, const Sk4f& dst) {
    return src + dst * (1 - alpha(src));
}
...
static Sk4f xor_4f(const Sk4f& src, const Sk4f& dst) {
    return src * (1 - alpha(dst)) + dst * (1-alpha(src));
}

and make the table as

    proc_4f<srcover_4f>,
    ...
    proc_4f<xor_4f>,

https://codereview.chromium.org/1670063002/diff/60001/src/core/SkXfermode.cpp...
src/core/SkXfermode.cpp:113: return as_pm4f(as_4f(dst) + as_4f(src) * Sk4f(1 -
dst.a()));
return srcover_proc4f(dst, src);  etc ?

[reed1, 2016-02-08 19:52:49]

ptal

https://codereview.chromium.org/1670063002/diff/60001/src/core/SkXfermode.cpp
File src/core/SkXfermode.cpp (right):

https://codereview.chromium.org/1670063002/diff/60001/src/core/SkXfermode.cpp...
src/core/SkXfermode.cpp:102: static SkPM4f srcover_proc4f(const SkPM4f& src,
const SkPM4f& dst) {
On 2016/02/08 18:27:22, mtklein wrote:
> Maybe we can make these easier to read with some little wrappers?
> 
> E.g.
> 
> template <Sk4f (*Proc)(const Sk4f&, const Sk4f&)>
> SkPM4f proc_4f(const SkPM4f& src, const SkPM4f& dst) {
>    return as_pm4f(Proc(as_4f(src), as_4f(dst));
> }
> 
> static Sk4f alpha(const Sk4f& x) {
>    return Sk4f(x.kth<SkPM4f::A>());
> }
> 
> then write all these as
> 
> static Sk4f srcover_4f(const Sk4f& src, const Sk4f& dst) {
>     return src + dst * (1 - alpha(src));
> }
> ...
> static Sk4f xor_4f(const Sk4f& src, const Sk4f& dst) {
>     return src * (1 - alpha(dst)) + dst * (1-alpha(src));
> }
> 
> and make the table as
> 
>     proc_4f<srcover_4f>,
>     ...
>     proc_4f<xor_4f>,

Done.

[reed1, 2016-02-08 19:52:56]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-08 19:53:09]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670063002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670063002/80001

[commit-bot: I haz the power, 2016-02-08 20:22:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-08 20:22:10]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-02-08 20:25:07]

lgtm

https://codereview.chromium.org/1670063002/diff/80001/src/core/SkXfermode.cpp
File src/core/SkXfermode.cpp (right):

https://codereview.chromium.org/1670063002/diff/80001/src/core/SkXfermode.cpp...
src/core/SkXfermode.cpp:73: return pin_1(s * inv_alpha(d) + d * inv_alpha(s) + s
* d);
Amazingly, pretty sure this doesn't require a pin.

[reed1, 2016-02-08 20:30:58]

https://codereview.chromium.org/1670063002/diff/80001/src/core/SkXfermode.cpp
File src/core/SkXfermode.cpp (right):

https://codereview.chromium.org/1670063002/diff/80001/src/core/SkXfermode.cpp...
src/core/SkXfermode.cpp:73: return pin_1(s * inv_alpha(d) + d * inv_alpha(s) + s
* d);
On 2016/02/08 20:25:07, mtklein wrote:
> Amazingly, pretty sure this doesn't require a pin.

Done.

[reed1, 2016-02-08 20:31:02]

The CQ bit was checked by reed@google.com

[reed1, 2016-02-08 20:31:02]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1670063002/#ps100001
(title: "remove pin for modulate")

[commit-bot: I haz the power, 2016-02-08 20:31:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1670063002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1670063002/100001

[commit-bot: I haz the power, 2016-02-08 20:56:59]

Description was changed from

==========
extend modecolorfilter to 4f

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
extend modecolorfilter to 4f

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/3125565804054691b110b4731bc5a32070fab780
==========

[commit-bot: I haz the power, 2016-02-08 20:56:59]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/3125565804054691b110b4731bc5a32070fab780