media/filters/chunk_demuxer.h - Issue 1670033002: Reland: MSE: Relax the 'media segment must begin with keyframe' requirement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/chunk_demuxer.h

Issue 1670033002: Reland: MSE: Relax the 'media segment must begin with keyframe' requirement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment responses, rebase, new CHECK_LT in SBR is failing. Investigating still. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/filters/chunk_demuxer.h

diff --git a/media/filters/chunk_demuxer.h b/media/filters/chunk_demuxer.h

index 6954793aa8a5ebcd204cba3ae9248a5a93d7101f..2425412802433b131346c26518dd63ac0c62d4ef 100644

--- a/media/filters/chunk_demuxer.h

+++ b/media/filters/chunk_demuxer.h

@@ -80,8 +80,8 @@ class MEDIA_EXPORT ChunkDemuxerStream : public DemuxerStream {

size_t GetBufferedSize() const;

// Signal to the stream that buffers handed in through subsequent calls to

- // Append() belong to a media segment that starts at |start_timestamp|.

- void OnNewMediaSegment(DecodeTimestamp start_timestamp);

+ // Append() belong to a coded frame group that starts at |start_timestamp|.

+ void OnStartOfCodedFrameGroup(DecodeTimestamp start_timestamp);

// Called when midstream config updates occur.

// Returns true if the new config is accepted.

« no previous file with comments | « no previous file | media/filters/chunk_demuxer.cc » ('j') | media/filters/source_buffer_stream_unittest.cc » ('J')