Issue 1669993002: Revert of Add the possibility to keep several version of the VS toolchain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1669993002: Revert of Add the possibility to keep several version of the VS toolchain. (Closed)

Created:
4 years, 10 months ago by brucedawson

Modified:
4 years, 10 months ago

Reviewers:
Sébastien Marchand, scottmg

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

Revert of Add the possibility to keep several version of the VS toolchain. (patchset #8 id:160001 of https://codereview.chromium.org/1634923002/ ) Reason for revert: Suspected of causing goma errors on some machines when using VS 2015. The suspicion is that the longer paths are causing problems. Original issue's description: > Add the possibility to keep several version of the VS toolchain. > > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298557 TBR=scottmg@chromium.org,sebmarchand@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -135 lines)			Patch
	M	win_toolchain/get_toolchain_if_necessary.py	View		8 chunks	+53 lines, -134 lines	0 comments	Download
	M	win_toolchain/package_from_installed.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brucedawson

Created Revert of Add the possibility to keep several version of the VS toolchain.

4 years, 10 months ago (2016-02-04 23:47:58 UTC) #1

brucedawson

4 years, 10 months ago (2016-02-05 00:00:23 UTC) #2

I didn't realize this had sent mail. I do want to revert this but given that I
can't download it with "git cl patch" I am skeptical about whether it will land.
Investigating...

I discussed with sebmarchand@ already.

Expand Messages | Collapse Messages