Fix ARM assembler to pop registers in reverse order of pushes.

src/IceInstARM32.h

 //===- subzero/src/IceInstARM32.h - ARM32 machine instructions --*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 1076 matching lines @@
   void dump(const Cfg *Func) const override;
 
 protected:
   InstARM32RegisterStackOp(Cfg *Func, InstKindARM32 Kind, SizeT Maxsrcs,
                            Variable *Dest)
       : InstARM32(Func, Kind, Maxsrcs, Dest) {}
   void emitUsingForm(const Cfg *Func, const EmitForm Form) const;
   void emitGPRsAsText(const Cfg *Func) const;
   void emitSRegsAsText(const Cfg *Func, const Variable *BaseReg,
                        SizeT Regcount) const;
+  void emitSRegsOp(const Cfg *Func, const EmitForm, const Variable *BaseReg,
+                   SizeT RegCount, SizeT InstIndex) const;
   virtual const char *getDumpOpcode() const { return getGPROpcode(); }
   virtual const char *getGPROpcode() const = 0;
   virtual const char *getSRegOpcode() const = 0;
   virtual Variable *getStackReg(SizeT Index) const = 0;
   virtual SizeT getNumStackRegs() const = 0;
   virtual void emitSingleGPR(const Cfg *Func, const EmitForm Form,
                              const Variable *Reg) const = 0;
   virtual void emitMultipleGPRs(const Cfg *Func, const EmitForm Form,
                                 IValueT Registers) const = 0;
   virtual void emitSRegs(const Cfg *Func, const EmitForm Form,
                          const Variable *BaseReg, SizeT RegCount) const = 0;
 };
 
 /// Pops a list of registers. It may be a list of GPRs, or a list of VFP "s"
 /// regs, but not both. In any case, the list must be sorted.
-class InstARM32Pop : public InstARM32RegisterStackOp {
+class InstARM32Pop final : public InstARM32RegisterStackOp {
   InstARM32Pop() = delete;
   InstARM32Pop(const InstARM32Pop &) = delete;
   InstARM32Pop &operator=(const InstARM32Pop &) = delete;
 
 public:
   static InstARM32Pop *create(Cfg *Func, const VarList &Dests) {
     return new (Func->allocate<InstARM32Pop>()) InstARM32Pop(Func, Dests);
   }
   static bool classof(const Inst *Instr) { return isClassof(Instr, Pop); }
 
 private:
   InstARM32Pop(Cfg *Func, const VarList &Dests);
   virtual const char *getGPROpcode() const final;
   virtual const char *getSRegOpcode() const final;
   Variable *getStackReg(SizeT Index) const final;
   SizeT getNumStackRegs() const final;
   void emitSingleGPR(const Cfg *Func, const EmitForm Form,
                      const Variable *Reg) const final;
   void emitMultipleGPRs(const Cfg *Func, const EmitForm Form,
                         IValueT Registers) const final;
   void emitSRegs(const Cfg *Func, const EmitForm Form, const Variable *BaseReg,
                  SizeT RegCount) const final;
-
   VarList Dests;
 };
 
 /// Pushes a list of registers. Just like Pop (see above), the list may be of
 /// GPRs, or VFP "s" registers, but not both.
-class InstARM32Push : public InstARM32RegisterStackOp {
+class InstARM32Push final : public InstARM32RegisterStackOp {
   InstARM32Push() = delete;
   InstARM32Push(const InstARM32Push &) = delete;
   InstARM32Push &operator=(const InstARM32Push &) = delete;
 
 public:
   static InstARM32Push *create(Cfg *Func, const VarList &Srcs) {
     return new (Func->allocate<InstARM32Push>()) InstARM32Push(Func, Srcs);
   }
   static bool classof(const Inst *Instr) { return isClassof(Instr, Push); }
 
@@ skipping 346 matching lines @@
 // violations and link errors.
 
 template <> void InstARM32Ldr::emit(const Cfg *Func) const;
 template <> void InstARM32Movw::emit(const Cfg *Func) const;
 template <> void InstARM32Movt::emit(const Cfg *Func) const;
 
 } // end of namespace ARM32
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEINSTARM32_H