Provide more error-handling customization.

test/with_guarantees_test.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:stream_channel/stream_channel.dart';
 import 'package:test/test.dart';
 
 import 'utils.dart';
@@ skipping 89 matching lines @@
     sinkController.stream.listen(
         expectAsync((_) {}, count: 0),
         onDone: expectAsync(() {}, count: 0));
     await pumpEventQueue();
   });
 
   test("forwards errors to the other endpoint", () {
     channel.sink.addError("error");
     expect(sinkController.stream.first, throwsA("error"));
   });
+
+  test("Sink.done completes once the stream is done", () {
+    channel.stream.listen(null);
+    expect(channel.sink.done, completes);
+    streamController.close();
+  });
+
+  group("with allowSinkErrors: false", () {
+    setUp(() {
+      streamController = new StreamController();
+      sinkController = new StreamController();
+      channel = new StreamChannel.withGuarantees(
+          streamController.stream, sinkController.sink, allowSinkErrors: false);
+    });
+
+    test("forwards errors to Sink.done but not the stream", () {
+      channel.sink.addError("oh no");
+      expect(channel.sink.done, throwsA("oh no"));
+      sinkController.stream.listen(null, onError: expectAsync((_) {}, count: 0));

[tjblasi, 2016/02/04 23:16:01]

line length (might just be Chromium Code Reviews UI)

+    });
+
+    test("adding an error causes the stream to emit a done event", () {
+      expect(channel.sink.done, throwsA("oh no"));
+
+      streamController.add(1);
+      streamController.add(2);
+      streamController.add(3);
+
+      expect(channel.stream.listen(expectAsync((event) {
+        if (event == 2) channel.sink.addError("oh no");
+      }, count: 2)).asFuture(), completes);
+    });
+
+    test("adding an error closes the inner sink", () {
+      channel.sink.addError("oh no");
+      expect(channel.sink.done, throwsA("oh no"));
+      expect(sinkController.stream.toList(), completion(isEmpty));
+    });
+  });
 }