Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1669943002: Chromoting iOS src directories should be ignored by the chromium checkout. (Closed)

Created:
4 years, 10 months ago by nicholss
Modified:
4 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add remoting iOS dirs to .gitignore. Committed: https://crrev.com/27ee0707363b9ec52202a1c394f7cacf866a9cfe Cr-Commit-Position: refs/heads/master@{#373850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M .gitignore View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
nicholss
4 years, 10 months ago (2016-02-05 17:38:32 UTC) #3
Sergey Ulanov
Suggest rewording the description, e.g. "Add remoting iOS dirs to .gitignore." With the current description ...
4 years, 10 months ago (2016-02-05 17:41:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669943002/1
4 years, 10 months ago (2016-02-05 17:54:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 18:17:56 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/27ee0707363b9ec52202a1c394f7cacf866a9cfe Cr-Commit-Position: refs/heads/master@{#373850}
4 years, 10 months ago (2016-02-05 18:20:26 UTC) #11
sdefresne
4 years, 10 months ago (2016-02-08 18:35:07 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1675363002/ by sdefresne@chromium.org.

The reason for reverting is: This is breaking dowsntream iOS tree as it prevent
the bots to add any new file in ios_internal..

Powered by Google App Engine
This is Rietveld 408576698