Issue 166993002: Make a single HeapEntry per single JSArrayBuffer data in heap snapshot.

Issue 166993002: Make a single HeapEntry per single JSArrayBuffer data in heap snapshot. (Closed)

Created:
6 years, 10 months ago by alph

Modified:
6 years, 10 months ago

Reviewers:
Dmitry Lomov (no reviews), yurys, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make a single HeapEntry per single JSArrayBuffer data in heap snapshot. It turned out that JSArrayBuffer's may share their backing_store so the backing_store should go through hash map registration just like other heap objects, so they won't be reported twice. BUG=341741 LOG=N R=dslomov@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19416

Patch Set 1 #

Patch Set 2 : Added a test. #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -8 lines)			Patch
M	src/heap-snapshot-generator.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/heap-snapshot-generator.cc	View	1	2 chunks	+20 lines, -4 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1	1 chunk	+45 lines, -0 lines	1 comment	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

https://codereview.chromium.org/166993002/diff/70001/test/cctest/test-heap-profiler.cc File test/cctest/test-heap-profiler.cc (right): https://codereview.chromium.org/166993002/diff/70001/test/cctest/test-heap-profiler.cc#newcode2406 test/cctest/test-heap-profiler.cc:2406: TEST(ArrayBufferSharedBackingStore) { I'd prefer a test that allocates ArrayBuffers ...

6 years, 10 months ago (2014-02-17 15:26:36 UTC) #7

alph

6 years, 10 months ago (2014-02-17 15:42:34 UTC) #8

Message was sent while issue was closed.

On 2014/02/17 15:26:36, Dmitry Lomov (chromium) wrote:
>
https://codereview.chromium.org/166993002/diff/70001/test/cctest/test-heap-pr...
> File test/cctest/test-heap-profiler.cc (right):
> 
>
https://codereview.chromium.org/166993002/diff/70001/test/cctest/test-heap-pr...
> test/cctest/test-heap-profiler.cc:2406: TEST(ArrayBufferSharedBackingStore) {
> I'd prefer a test that allocates ArrayBuffers with shared backing store
through
> the API, and does not rely on SinTable implementation.
> 
> What do you think?

Agree. I'll try that.

Expand Messages | Collapse Messages