Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Unified Diff: Source/core/inspector/PageRuntimeAgent.cpp

Issue 1669913003: Fix bug where Dart execution contexts were getting the wrong execution context id. (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/2454_1
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorRuntimeAgent.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/PageRuntimeAgent.cpp
diff --git a/Source/core/inspector/PageRuntimeAgent.cpp b/Source/core/inspector/PageRuntimeAgent.cpp
index 442b959b5be8b2d671ae922f468c645b3fba774e..12958c11b56cf613856366529f0f43909fd76d16 100644
--- a/Source/core/inspector/PageRuntimeAgent.cpp
+++ b/Source/core/inspector/PageRuntimeAgent.cpp
@@ -32,6 +32,7 @@
#include "core/inspector/PageRuntimeAgent.h"
#include "bindings/core/dart/DartController.h"
+#include "bindings/core/dart/DartInspectorRuntimeAgent.h"
#include "bindings/core/v8/DOMWrapperWorld.h"
#include "bindings/core/v8/ScriptController.h"
#include "bindings/core/v8/ScriptState.h"
@@ -190,7 +191,6 @@ void PageRuntimeAgent::reportExecutionContextCreation()
void PageRuntimeAgent::notifyDartContextCreated(const String& frameId, ScriptState* v8ScriptState)
{
ExecutionContext* executionContext = v8ScriptState->executionContext();
- int executionContextId = injectedScriptManager()->injectedScriptIdFor(v8ScriptState);
DartController* dartController = DartController::retrieve(executionContext);
if (dartController) {
Vector<DartScriptState*> scriptStates;
@@ -198,7 +198,7 @@ void PageRuntimeAgent::notifyDartContextCreated(const String& frameId, ScriptSta
// TODO(jacobr): now that there is a human readable name field we could possibly leave orign blank.
for (size_t i = 0; i< scriptStates.size(); i++) {
DartScriptState* state = scriptStates[i];
- addExecutionContextToFrontendDart(executionContextId, "", *(state->name()), *(state->name()), frameId, "Dart", state->libraryId());
+ m_dart->addExecutionContextToFrontendHelper(state, true, *(state->name()), frameId);
}
}
}
« no previous file with comments | « Source/core/inspector/InspectorRuntimeAgent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698