Add stub implementations to new WebViewDelegate methods.

Add stub implementations to new WebViewDelegate methods.

There are IME use cases for returning a different value from
getHandler() and findFocus(), in order to make InputMethodManager
communicate with a separate IME thread.  Currently, it's cumbersome to
do so in WebView because we cannot alter View-inherited methods without
a framework change.

This patch pair adds the framework-side override and adds no-op stub
methods on the Chromium side, to enable us to take this approach in the
future.

The Android-side patch is at https://googleplex-android-review.git.corp.google.com/859715

BUG=569556
Committed: https://crrev.com/b725a602e2cdd76ce60f483b138763404bb1b354
Cr-Commit-Position: refs/heads/master@{#373703}

[aelias_OOO_until_Jul13, 2016-02-04 21:16:15]

Description was changed from

==========
Add stub implementations to new WebViewDelegate methods.

There are IME use cases for returning a different value from
getHandler() and findFocus(), in order to make InputMethodManager
communicate with a separate IME thread.  Currently, it's cumbersome to
do so in WebView because we cannot alter View-inherited methods without
a framework change.

This patch pair adds the framework-side override and adds no-op stub
methods on the Chromium side, to enable us to take this approach in the
future.

BUG=569556
==========

to

==========
Add stub implementations to new WebViewDelegate methods.

There are IME use cases for returning a different value from
getHandler() and findFocus(), in order to make InputMethodManager
communicate with a separate IME thread.  Currently, it's cumbersome to
do so in WebView because we cannot alter View-inherited methods without
a framework change.

This patch pair adds the framework-side override and adds no-op stub
methods on the Chromium side, to enable us to take this approach in the
future.  The Android-side patch is at
https://googleplex-android-review.git.corp.google.com/859715

BUG=569556
==========

[aelias_OOO_until_Jul13, 2016-02-04 22:04:20]

aelias@chromium.org changed reviewers:
+ sgurun@chromium.org

[aelias_OOO_until_Jul13, 2016-02-04 22:04:20]

Hi Selim, PTAL.

[aelias_OOO_until_Jul13, 2016-02-04 22:53:41]

Description was changed from

==========
Add stub implementations to new WebViewDelegate methods.

There are IME use cases for returning a different value from
getHandler() and findFocus(), in order to make InputMethodManager
communicate with a separate IME thread.  Currently, it's cumbersome to
do so in WebView because we cannot alter View-inherited methods without
a framework change.

This patch pair adds the framework-side override and adds no-op stub
methods on the Chromium side, to enable us to take this approach in the
future.  The Android-side patch is at
https://googleplex-android-review.git.corp.google.com/859715

BUG=569556
==========

to

==========
Add stub implementations to new WebViewDelegate methods.

There are IME use cases for returning a different value from
getHandler() and findFocus(), in order to make InputMethodManager
communicate with a separate IME thread.  Currently, it's cumbersome to
do so in WebView because we cannot alter View-inherited methods without
a framework change.

This patch pair adds the framework-side override and adds no-op stub
methods on the Chromium side, to enable us to take this approach in the
future.

The Android-side patch is at
https://googleplex-android-review.git.corp.google.com/859715
The downstream glue layer patch is at
https://chrome-internal-review.googlesource.com/247104

BUG=569556
==========

[sgurun-gerrit only, 2016-02-04 22:55:49]

On 2016/02/04 22:04:20, aelias wrote:
> Hi Selim, PTAL.

the implementation needs to go to internal glue layer, let's close this.

[boliu, 2016-02-04 22:56:22]

On 2016/02/04 22:55:49, sgurun wrote:
> On 2016/02/04 22:04:20, aelias wrote:
> > Hi Selim, PTAL.
> 
> the implementation needs to go to internal glue layer, let's close this.

wait, why? this is not confidential

[sgurun-gerrit only, 2016-02-04 23:15:06]

On 2016/02/04 22:56:22, boliu wrote:
> On 2016/02/04 22:55:49, sgurun wrote:
> > On 2016/02/04 22:04:20, aelias wrote:
> > > Hi Selim, PTAL.
> > 
> > the implementation needs to go to internal glue layer, let's close this.
> 
> wait, why? this is not confidential

yes in this case, fine.

[sgurun-gerrit only, 2016-02-04 23:15:10]

On 2016/02/04 22:56:22, boliu wrote:
> On 2016/02/04 22:55:49, sgurun wrote:
> > On 2016/02/04 22:04:20, aelias wrote:
> > > Hi Selim, PTAL.
> > 
> > the implementation needs to go to internal glue layer, let's close this.
> 
> wait, why? this is not confidential

yes in this case, fine.

[sgurun-gerrit only, 2016-02-04 23:21:13]

On 2016/02/04 23:15:10, sgurun wrote:
> On 2016/02/04 22:56:22, boliu wrote:
> > On 2016/02/04 22:55:49, sgurun wrote:
> > > On 2016/02/04 22:04:20, aelias wrote:
> > > > Hi Selim, PTAL.
> > > 
> > > the implementation needs to go to internal glue layer, let's close this.
> > 
> > wait, why? this is not confidential
> 
> yes in this case, fine.

can you also update the CL description to reflect that no downstream glue layer
patch is landing.

We use view methods to start chromium engine (and post them to the right thread)
but in this case since it does not look needed since it is just returning the
parent's parameter.

lgtm

[boliu, 2016-02-04 23:23:07]

On 2016/02/04 23:21:13, sgurun wrote:
> On 2016/02/04 23:15:10, sgurun wrote:
> > On 2016/02/04 22:56:22, boliu wrote:
> > > On 2016/02/04 22:55:49, sgurun wrote:
> > > > On 2016/02/04 22:04:20, aelias wrote:
> > > > > Hi Selim, PTAL.
> > > > 
> > > > the implementation needs to go to internal glue layer, let's close this.
> > > 
> > > wait, why? this is not confidential
> > 
> > yes in this case, fine.
> 
> can you also update the CL description to reflect that no downstream glue
layer
> patch is landing.

fwiw, we have a script to merge upstream glue changes to downstream (bottom of
goto/android-webview/building-webview/adding-java-apis-to-webview), probably
should use that rather than hand writing a copy of this

but shouldn't hurt either way

> 
> We use view methods to start chromium engine (and post them to the right
thread)
> but in this case since it does not look needed since it is just returning the
> parent's parameter.
> 
> lgtm

[aelias_OOO_until_Jul13, 2016-02-04 23:24:27]

Description was changed from

==========
Add stub implementations to new WebViewDelegate methods.

There are IME use cases for returning a different value from
getHandler() and findFocus(), in order to make InputMethodManager
communicate with a separate IME thread.  Currently, it's cumbersome to
do so in WebView because we cannot alter View-inherited methods without
a framework change.

This patch pair adds the framework-side override and adds no-op stub
methods on the Chromium side, to enable us to take this approach in the
future.

The Android-side patch is at
https://googleplex-android-review.git.corp.google.com/859715
The downstream glue layer patch is at
https://chrome-internal-review.googlesource.com/247104

BUG=569556
==========

to

==========
Add stub implementations to new WebViewDelegate methods.

There are IME use cases for returning a different value from
getHandler() and findFocus(), in order to make InputMethodManager
communicate with a separate IME thread.  Currently, it's cumbersome to
do so in WebView because we cannot alter View-inherited methods without
a framework change.

This patch pair adds the framework-side override and adds no-op stub
methods on the Chromium side, to enable us to take this approach in the
future.

The Android-side patch is at
https://googleplex-android-review.git.corp.google.com/859715

BUG=569556
==========

[aelias_OOO_until_Jul13, 2016-02-04 23:25:08]

On 2016/02/04 at 23:21:13, sgurun wrote:
> can you also update the CL description to reflect that no downstream glue
layer patch is landing.

Done.

[aelias_OOO_until_Jul13, 2016-02-04 23:25:18]

The CQ bit was checked by aelias@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-04 23:27:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1669873003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1669873003/20001

[commit-bot: I haz the power, 2016-02-05 00:12:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-05 00:12:56]

Dry run: This issue passed the CQ dry run.

[aelias_OOO_until_Jul13, 2016-02-05 01:06:33]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2016-02-05 01:07:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1669873003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1669873003/20001

[commit-bot: I haz the power, 2016-02-05 01:15:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-05 01:16:27]

Description was changed from

==========
Add stub implementations to new WebViewDelegate methods.

There are IME use cases for returning a different value from
getHandler() and findFocus(), in order to make InputMethodManager
communicate with a separate IME thread.  Currently, it's cumbersome to
do so in WebView because we cannot alter View-inherited methods without
a framework change.

This patch pair adds the framework-side override and adds no-op stub
methods on the Chromium side, to enable us to take this approach in the
future.

The Android-side patch is at
https://googleplex-android-review.git.corp.google.com/859715

BUG=569556
==========

to

==========
Add stub implementations to new WebViewDelegate methods.

There are IME use cases for returning a different value from
getHandler() and findFocus(), in order to make InputMethodManager
communicate with a separate IME thread.  Currently, it's cumbersome to
do so in WebView because we cannot alter View-inherited methods without
a framework change.

This patch pair adds the framework-side override and adds no-op stub
methods on the Chromium side, to enable us to take this approach in the
future.

The Android-side patch is at
https://googleplex-android-review.git.corp.google.com/859715

BUG=569556

Committed: https://crrev.com/b725a602e2cdd76ce60f483b138763404bb1b354
Cr-Commit-Position: refs/heads/master@{#373703}
==========

[commit-bot: I haz the power, 2016-02-05 01:16:28]

Patchset 2 (id:??) landed as
https://crrev.com/b725a602e2cdd76ce60f483b138763404bb1b354
Cr-Commit-Position: refs/heads/master@{#373703}