chrome/test/BUILD.gn - Issue 1669793002: mac_views_browser: fixed interactive_ui_tests compilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/BUILD.gn

Issue 1669793002: mac_views_browser: fixed interactive_ui_tests compilation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review fixes Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/BUILD.gn

diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn

index 757fbbe9428a847b6563516ca9d6cd8537a6b916..54d8e527af13772e5be71715bee9491d5d3d1782 100644

--- a/chrome/test/BUILD.gn

+++ b/chrome/test/BUILD.gn

@@ -493,6 +493,24 @@ if (!is_android) {

# when we tried to pull it up to the common.gypi level, it broke other

# things like the ui and startup tests. *shrug*

ldflags += [ "-Wl,-ObjC" ]

+ if (mac_views_browser) {

tapted 2016/02/07 23:15:30 nit: comment before `The browser window can be vie

themblsha 2016/02/08 17:08:58 Done.

+ sources += rebase_path(

+ chrome_tests_gypi_values.chrome_interactive_ui_test_views_non_mac_sources,

+ ".",

+ "//chrome")

+ # Aura depended tests.

+ sources -= [

+ "../browser/ui/views/bookmarks/bookmark_bar_view_test.cc",

+ "../browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc",

+ ]

+ } else {

+ sources += rebase_path(

+ chrome_tests_gypi_values.chrome_interactive_ui_test_cocoa_sources,

+ ".",

+ "//chrome")

+ }

}

if (cld_version == 2) {

« chrome/chrome_tests.gypi ('K') | « chrome/chrome_tests.gypi ('k') | chrome/test/base/interactive_test_utils.h » ('j') | chrome/test/base/interactive_test_utils_common_views.cc » ('J')