chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc - Issue 1669793002: mac_views_browser: fixed interactive_ui_tests compilation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc

Issue 1669793002: mac_views_browser: fixed interactive_ui_tests compilation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review fixes Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc b/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc

index 8c339aa013821e60fa8186aa980c48a5a5edf963..a7ee1b0dddaad2e24637a9688dd0c9552cbe9634 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc

@@ -162,9 +162,10 @@ IN_PROC_BROWSER_TEST_F(ToolbarViewInteractiveUITest,

ToolbarActionView* view = browser_actions()->GetToolbarActionViewAt(0);

ASSERT_TRUE(view);

- gfx::Point browser_action_view_loc = test::GetCenterInScreenCoordinates(view);

- gfx::Point app_button_loc =

- test::GetCenterInScreenCoordinates(toolbar_view()->app_menu_button());

+ gfx::Point browser_action_view_loc =

+ ui_test_utils::GetCenterInScreenCoordinates(view);

+ gfx::Point app_button_loc = ui_test_utils::GetCenterInScreenCoordinates(

+ toolbar_view()->app_menu_button());

// Perform a drag and drop from the browser action view to the app button,

// which should open the app menu.

« no previous file with comments | « chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc ('k') | chrome/chrome_tests.gypi » ('j') | chrome/chrome_tests.gypi » ('J')