mac_views_browser: fixed interactive_ui_tests compilation.

chrome/chrome_tests.gypi

Index: chrome/chrome_tests.gypi
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index d7dd12edf1eb07c210736784921c639b48fd8285..a79ee01e1e31a51433cdaf50bff1872decc16eee 100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -1048,7 +1048,6 @@
       'browser/ui/cocoa/apps/quit_with_apps_controller_mac_interactive_uitest.mm',
       'browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm',
       'browser/ui/cocoa/panels/panel_cocoa_browsertest.mm',
-      'browser/ui/cocoa/translate/translate_bubble_test_utils_cocoa.mm',
       'browser/ui/exclusive_access/flash_fullscreen_interactive_browsertest.cc',
       'browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc',
       'browser/ui/exclusive_access/fullscreen_controller_state_interactive_browsertest.cc',
@@ -1083,7 +1082,7 @@
       'test/base/interactive_test_utils_aura.cc',
       'test/base/interactive_test_utils_aura.h',
       'test/base/interactive_test_utils_mac.mm',
-      'test/base/interactive_test_utils_views.cc',
+      'test/base/interactive_test_utils_common_views.cc',
       'test/base/interactive_test_utils_win.cc',
       'test/base/interactive_ui_tests_main.cc',
       'test/base/view_event_test_platform_part.h',
@@ -1117,6 +1116,11 @@
       'test/base/view_event_test_base.cc',
       'test/base/view_event_test_base.h',
     ],
+    # Mac sources, except when mac_views_browser==1

[tapted, 2016/02/05 05:11:11]

nit: full stop after comment

[kirr, 2016/02/05 13:26:23]

Done.

+    'chrome_interactive_ui_test_cocoa_sources': [
+      'browser/ui/cocoa/translate/translate_bubble_test_utils_cocoa.mm',
+      'test/base/interactive_test_utils_cocoa.mm',
+    ],
     'chrome_interactive_ui_test_app_list_sources': [
       'browser/ui/app_list/app_list_service_interactive_uitest.cc',
       'browser/ui/app_list/app_list_service_mac_interactive_uitest.mm',
@@ -1161,6 +1165,7 @@
       'browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc',
       'browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc',
       'browser/ui/views/translate/translate_bubble_test_utils_views.cc',
+      'test/base/interactive_test_utils_views.cc',
     ],
     'chrome_interactive_ui_test_notifications_sources': [
       'browser/extensions/api/notifications/notifications_apitest.cc',
@@ -1711,6 +1716,21 @@
           ],
           # See comment about the same line in chrome/chrome_tests.gypi.
           'xcode_settings': {'OTHER_LDFLAGS': ['-Wl,-ObjC']},
+          'conditions' : [

[tapted, 2016/02/05 05:11:11]

I've been putting a comment here, like

# The browser window can be views or Cocoa on Mac. Test accordingly.

Then this needs a corresponding BUILD.gn change in case we forget about it and
accidentally lose some test coverage

[kirr, 2016/02/05 13:26:23]

Done.

+            ['mac_views_browser==1', {
+              'sources': [ '<@(chrome_interactive_ui_test_views_non_mac_sources)' ],
+              # Following tests needs a refactoring to works with mac_views
+              'sources!': [
+                # Cocoa depended tests
+                'browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm',

[tapted, 2016/02/05 05:11:11]

Can this just move into chrome_interactive_ui_test_cocoa_sources?

[kirr, 2016/02/05 13:26:23]

Done. I wanted to make these strings remarkable (to show that we need to
refactor tests).

+                # Aura depended tests
+                'browser/ui/views/bookmarks/bookmark_bar_view_test.cc',
+                'browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc',
+              ]
+            }, {
+              'sources': [ '<@(chrome_interactive_ui_test_cocoa_sources)' ],
+            }],  # mac_views_browser==1
+          ],
         }, {  # Non-Mac.
           'sources': [ '<@(chrome_interactive_ui_test_views_non_mac_sources)' ],
         }],