Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1669773002: [math] Fix Math.hypot to properly call ToNumber on all arguments. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[math] Fix Math.hypot to properly call ToNumber on all arguments. The spec requires all Math functions to first call ToNumber on all arguments before doing any other observable operation. So early return in case of Infinity is not valid. Drive-by-fix: Remove the use of %_Arguments / %_ArgumentsLength and use (strict) arguments instead of allocating a temporary InternalArray explicitly. R=yangguo@chromium.org Committed: https://crrev.com/264fa75e529562a6f5df97c5daf1867cd81c58d2 Cr-Commit-Position: refs/heads/master@{#33717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M src/js/math.js View 2 chunks +5 lines, -8 lines 0 comments Download
M test/mjsunit/to_number_order.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-04 06:59:28 UTC) #1
Yang
On 2016/02/04 06:59:28, Benedikt Meurer wrote: lgtm.
4 years, 10 months ago (2016-02-04 07:01:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669773002/1
4 years, 10 months ago (2016-02-04 07:01:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 07:22:46 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 07:23:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/264fa75e529562a6f5df97c5daf1867cd81c58d2
Cr-Commit-Position: refs/heads/master@{#33717}

Powered by Google App Engine
This is Rietveld 408576698