chrome/renderer/searchbox/searchbox_extension.cc - Issue 1669723002: NTP: don't allow navigateContentWindow to navigate where it pleases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/searchbox/searchbox_extension.cc

Issue 1669723002: NTP: don't allow navigateContentWindow to navigate where it pleases. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Better comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/searchbox/searchbox_extension.cc

diff --git a/chrome/renderer/searchbox/searchbox_extension.cc b/chrome/renderer/searchbox/searchbox_extension.cc

index 5dc7ae5ac91322ffd16f8e7eede21a2f2d861a8b..7e3af7acbd56f2b31effeb1550b5b91d746680d6 100644

--- a/chrome/renderer/searchbox/searchbox_extension.cc

+++ b/chrome/renderer/searchbox/searchbox_extension.cc

@@ -1164,7 +1164,9 @@ void SearchBoxExtensionWrapper::NavigateContentWindow(

DVLOG(1) << render_view << " NavigateContentWindow: " << destination_url;

- // Navigate the main frame.

+ // Navigate the main frame. Note that the security checks are enforced by the

+ // browser process in InstantService::IsValidURLForNavigation(), but some

+ // simple checks here are useful for avoiding unnecessary IPCs.

if (destination_url.is_valid() &&

!destination_url.SchemeIs(url::kJavaScriptScheme)) {

WindowOpenDisposition disposition = CURRENT_TAB;

« no previous file with comments | « chrome/browser/ui/search/search_tab_helper.cc ('k') | no next file » | no next file with comments »