Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1669663003: Revert of Work around exasperating Google3 Android build error. (Closed)

Created:
4 years, 10 months ago by dogben
Modified:
4 years, 10 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org, jcgregorio
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Work around exasperating Google3 Android build error. (patchset #1 id:1 of https://codereview.chromium.org/1649493005/ ) Reason for revert: This workaround no longer seems to be necessary. Original issue's description: > Work around exasperating Google3 Android build error. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1649493005 > > Committed: https://skia.googlesource.com/skia/+/900901fb1ba5170549670829fc8f9d9b590ff5f0 TBR=mtklein@google.com,reed@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ff172dab92b40af96cbf284588ab5ed20982a001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M include/core/SkXfermode.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dogben
Created Revert of Work around exasperating Google3 Android build error.
4 years, 10 months ago (2016-02-03 23:59:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669663003/1
4 years, 10 months ago (2016-02-04 00:00:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669663003/1
4 years, 10 months ago (2016-02-04 00:02:19 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 00:29:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ff172dab92b40af96cbf284588ab5ed20982a001

Powered by Google App Engine
This is Rietveld 408576698