Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: chrome/browser/translate/translate_ui_delegate.cc

Issue 166963002: TranslateManager is no longer a singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp
Patch Set: Rebase + review comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/translate/translate_ui_delegate.cc
diff --git a/chrome/browser/translate/translate_ui_delegate.cc b/chrome/browser/translate/translate_ui_delegate.cc
index c9114b7c1c96af536e159269920b61b2574e07e5..5c0eda75061a382ab1e525e462a81b064512190f 100644
--- a/chrome/browser/translate/translate_ui_delegate.cc
+++ b/chrome/browser/translate/translate_ui_delegate.cc
@@ -157,15 +157,19 @@ void TranslateUIDelegate::Translate() {
prefs_->ResetTranslationDeniedCount(GetOriginalLanguageCode());
prefs_->IncrementTranslationAcceptedCount(GetOriginalLanguageCode());
}
- TranslateManager::GetInstance()->TranslatePage(web_contents(),
- GetOriginalLanguageCode(),
- GetTargetLanguageCode());
+ TranslateManager* manager =
+ TranslateTabHelper::GetManagerFromWebContents(web_contents());
+ DCHECK(manager);
+ manager->TranslatePage(GetOriginalLanguageCode(), GetTargetLanguageCode());
UMA_HISTOGRAM_BOOLEAN(kPerformTranslate, true);
}
void TranslateUIDelegate::RevertTranslation() {
- TranslateManager::GetInstance()->RevertTranslation(web_contents());
+ TranslateManager* manager =
+ TranslateTabHelper::GetManagerFromWebContents(web_contents());
+ DCHECK(manager);
+ manager->RevertTranslation();
UMA_HISTOGRAM_BOOLEAN(kRevertTranslation, true);
}

Powered by Google App Engine
This is Rietveld 408576698