Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: chrome/browser/translate/translate_ui_delegate.cc

Issue 166963002: TranslateManager is no longer a singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp
Patch Set: Review comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/translate/translate_ui_delegate.h" 5 #include "chrome/browser/translate/translate_ui_delegate.h"
6 6
7 #include "base/i18n/string_compare.h" 7 #include "base/i18n/string_compare.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 150
151 std::string TranslateUIDelegate::GetTargetLanguageCode() const { 151 std::string TranslateUIDelegate::GetTargetLanguageCode() const {
152 return GetLanguageCodeAt(GetTargetLanguageIndex()); 152 return GetLanguageCodeAt(GetTargetLanguageIndex());
153 } 153 }
154 154
155 void TranslateUIDelegate::Translate() { 155 void TranslateUIDelegate::Translate() {
156 if (!web_contents()->GetBrowserContext()->IsOffTheRecord()) { 156 if (!web_contents()->GetBrowserContext()->IsOffTheRecord()) {
157 prefs_->ResetTranslationDeniedCount(GetOriginalLanguageCode()); 157 prefs_->ResetTranslationDeniedCount(GetOriginalLanguageCode());
158 prefs_->IncrementTranslationAcceptedCount(GetOriginalLanguageCode()); 158 prefs_->IncrementTranslationAcceptedCount(GetOriginalLanguageCode());
159 } 159 }
160 TranslateManager::GetInstance()->TranslatePage(web_contents(), 160 TranslateManager* manager =
161 GetOriginalLanguageCode(), 161 TranslateTabHelper::GetManagerFromWebContents(web_contents());
blundell 2014/02/18 09:21:46 DCHECK(manager) here and below
162 GetTargetLanguageCode()); 162 manager->TranslatePage(GetOriginalLanguageCode(), GetTargetLanguageCode());
163 163
164 UMA_HISTOGRAM_BOOLEAN(kPerformTranslate, true); 164 UMA_HISTOGRAM_BOOLEAN(kPerformTranslate, true);
165 } 165 }
166 166
167 void TranslateUIDelegate::RevertTranslation() { 167 void TranslateUIDelegate::RevertTranslation() {
168 TranslateManager::GetInstance()->RevertTranslation(web_contents()); 168 TranslateManager* manager =
169 TranslateTabHelper::GetManagerFromWebContents(web_contents());
170 manager->RevertTranslation();
169 171
170 UMA_HISTOGRAM_BOOLEAN(kRevertTranslation, true); 172 UMA_HISTOGRAM_BOOLEAN(kRevertTranslation, true);
171 } 173 }
172 174
173 void TranslateUIDelegate::TranslationDeclined(bool explicitly_closed) { 175 void TranslateUIDelegate::TranslationDeclined(bool explicitly_closed) {
174 if (!web_contents()->GetBrowserContext()->IsOffTheRecord()) { 176 if (!web_contents()->GetBrowserContext()->IsOffTheRecord()) {
175 prefs_->ResetTranslationAcceptedCount(GetOriginalLanguageCode()); 177 prefs_->ResetTranslationAcceptedCount(GetOriginalLanguageCode());
176 prefs_->IncrementTranslationDeniedCount(GetOriginalLanguageCode()); 178 prefs_->IncrementTranslationDeniedCount(GetOriginalLanguageCode());
177 } 179 }
178 180
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 prefs_->RemoveLanguagePairFromWhitelist(original_lang, target_lang); 247 prefs_->RemoveLanguagePairFromWhitelist(original_lang, target_lang);
246 248
247 UMA_HISTOGRAM_BOOLEAN(kAlwaysTranslateLang, true); 249 UMA_HISTOGRAM_BOOLEAN(kAlwaysTranslateLang, true);
248 } 250 }
249 251
250 std::string TranslateUIDelegate::GetPageHost() { 252 std::string TranslateUIDelegate::GetPageHost() {
251 content::NavigationEntry* entry = 253 content::NavigationEntry* entry =
252 web_contents()->GetController().GetActiveEntry(); 254 web_contents()->GetController().GetActiveEntry();
253 return entry ? entry->GetURL().HostNoBrackets() : std::string(); 255 return entry ? entry->GetURL().HostNoBrackets() : std::string();
254 } 256 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698