Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1669593002: Convert SpanApplierTest to a Robolectric test. (Closed)

Created:
4 years, 10 months ago by newt (away)
Modified:
4 years, 10 months ago
Reviewers:
Theresa
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert SpanApplierTest to a Robolectric test. This reduces the test time from dozens of seconds down to dozens of milliseconds. BUG=583598 Committed: https://crrev.com/f26a01f8e6cd8e5a15da768697f8eb59bf191154 Cr-Commit-Position: refs/heads/master@{#373363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -180 lines) Patch
M ui/android/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
D ui/android/javatests/src/org/chromium/ui/text/SpanApplierTest.java View 1 chunk +0 lines, -162 lines 0 comments Download
A + ui/android/junit/src/org/chromium/ui/text/SpanApplierTest.java View 6 chunks +19 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
newt (away)
PTAL
4 years, 10 months ago (2016-02-03 21:21:03 UTC) #2
Theresa
LGTM! Thank you for taking care of that TODO!
4 years, 10 months ago (2016-02-03 21:25:19 UTC) #3
newt (away)
It was so simple, I couldn't not do it :)
4 years, 10 months ago (2016-02-03 21:32:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669593002/1
4 years, 10 months ago (2016-02-03 21:35:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 22:35:43 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 22:36:40 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f26a01f8e6cd8e5a15da768697f8eb59bf191154
Cr-Commit-Position: refs/heads/master@{#373363}

Powered by Google App Engine
This is Rietveld 408576698