Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Issue 1669523004: [compiler] Allow optimization of functions with rest parameters. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Allow optimization of functions with rest parameters. The parser should have never done this. The AstNumbering takes care of disabling compilers for certain language constructs. TBR=rossberg@chromium.org Committed: https://crrev.com/85306a0a9d3388eac7e15f2858ed4d5eb015a627 Cr-Commit-Position: refs/heads/master@{#33720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/parsing/parser.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-04 08:36:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669523004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669523004/1
4 years, 10 months ago (2016-02-04 08:37:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 09:04:03 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 09:04:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85306a0a9d3388eac7e15f2858ed4d5eb015a627
Cr-Commit-Position: refs/heads/master@{#33720}

Powered by Google App Engine
This is Rietveld 408576698