Issue 16695006: Delegating yield does not re-box result objects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16695006: Delegating yield does not re-box result objects (Closed)

Created:
7 years, 6 months ago by wingo

Modified:
7 years, 6 months ago

Reviewers:
Michael Starzinger, rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Delegating yield does not re-box result objects Delegating yield (yield*) should just pass on the iterator results it receives instead of re-boxing them. R=rossberg@chromium.org TEST=mjsunit/harmony/generators-iteration BUG= Committed: http://code.google.com/p/v8/source/detail?r=15113

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase; make test pretty. #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -33 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1	3 chunks	+9 lines, -11 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1	3 chunks	+9 lines, -11 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1	3 chunks	+9 lines, -11 lines	0 comments	Download
M	test/mjsunit/harmony/generators-iteration.js	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wingo

As discussed on es-discuss last month, yield* should not re-box the result that it yields.

7 years, 6 months ago (2013-06-12 15:12:19 UTC) #1

rossberg

LGTM with nit https://codereview.chromium.org/16695006/diff/1/test/mjsunit/harmony/generators-iteration.js File test/mjsunit/harmony/generators-iteration.js (right): https://codereview.chromium.org/16695006/diff/1/test/mjsunit/harmony/generators-iteration.js#newcode373 test/mjsunit/harmony/generators-iteration.js:373: collect_results((function*(){return yield* results(expected);})())); Nit: spacing

7 years, 6 months ago (2013-06-13 09:53:18 UTC) #2

wingo

7 years, 6 months ago (2013-06-13 10:58:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r15113 (presubmit successful).

Expand Messages | Collapse Messages