Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1669493006: Incorrect setHasMediaQueries() when @media rule is dropped. (Closed)

Created:
4 years, 10 months ago by rune
Modified:
4 years, 10 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Incorrect setHasMediaQueries() when @media rule is dropped. Trying to insert an @media rule into a stylesheet were incorrectly marking the stylesheet as containing media queries before the media rule was dropped because it was inserted before an @namespace rule. That caused unnecessary rebuilding of rule sets for the stylesheet with the dropped rule when a media query evaluation changed in some other stylesheet. R=timloh@chromium.org Committed: https://crrev.com/27a835bef2bfe7bee393aa96a728dd5270f03a60 Cr-Commit-Position: refs/heads/master@{#373473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleSheetContents.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/core/css/StyleSheetContentsTest.cpp View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rune
ptal
4 years, 10 months ago (2016-02-04 01:19:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669493006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669493006/1
4 years, 10 months ago (2016-02-04 01:21:21 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-04 02:47:02 UTC) #5
Timothy Loh
lgtm
4 years, 10 months ago (2016-02-04 02:52:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669493006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669493006/1
4 years, 10 months ago (2016-02-04 06:33:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-04 06:40:01 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 06:41:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27a835bef2bfe7bee393aa96a728dd5270f03a60
Cr-Commit-Position: refs/heads/master@{#373473}

Powered by Google App Engine
This is Rietveld 408576698