Issue 1669473004: Beef up analysis server integration test messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1669473004: Beef up analysis server integration test messages. (Closed)

Created:
4 years, 10 months ago by Paul Berry

Modified:
4 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Beef up analysis server integration test messages. When an integration test fails, in can be difficult to figure out why, especially if the test had to forcibly terminate the analysis server process. These messages should help debug the problem. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/bc551cb3089bffae2b20b0dad23571e98dff5fbe

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -11 lines)			Patch
M	pkg/analysis_server/benchmark/integration/driver.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/integration/integration_tests.dart	View	7 chunks	+11 lines, -9 lines	0 comments	Download
M	pkg/analysis_server/test/timing/timing_framework.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

4 years, 10 months ago (2016-02-04 20:48:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bc551cb3089bffae2b20b0dad23571e98dff5fbe (presubmit successful).