[sql] Clean up sql::Recovery unit test.

[sql] Clean up sql::Recovery unit test.

Test baseline sql::Recovery::Rollback() operation.  Change
RecoveryCallback() to use AutoRecoverTable() rather than manual virtual
table setup.  Inject an artificial error to provoke callback in
RecoverCorruptTable rather than calling manually.

BUG=none

Committed: https://crrev.com/6ac39546b2c45d8a9b06ba08a19811f5f224934c
Cr-Commit-Position: refs/heads/master@{#373613}

[Scott Hess - ex-Googler, 2016-02-03 22:14:46]

shess@chromium.org changed reviewers:
+ rch@chromium.org

[Scott Hess - ex-Googler, 2016-02-03 22:14:46]

Random testing changes from other CLs.  I've put some time into getting the one
corruption case to auto-detect, but no success.

[Scott Hess - ex-Googler, 2016-02-03 22:44:51]

On 2016/02/03 22:14:46, Scott Hess wrote:
> Random testing changes from other CLs.  I've put some time into getting the
one
> corruption case to auto-detect, but no success.

Also, the reason the callback was using the virtual table directly is because it
was written after the virtual table was landed but before AutoRecoverTable() was
invented.  This change tests the same stack, and the raw virtual table is
probably too subtle for general use.

[Ryan Hamilton, 2016-02-04 20:24:19]

LGTM, I think. With one suggestion.

https://codereview.chromium.org/1669453003/diff/1/sql/recovery_unittest.cc
File sql/recovery_unittest.cc (right):

https://codereview.chromium.org/1669453003/diff/1/sql/recovery_unittest.cc#ne...
sql/recovery_unittest.cc:176: #if !defined(USE_SYSTEM_SQLITE)
Can you remove this now since you're not using the virtual table?

[Scott Hess - ex-Googler, 2016-02-04 20:47:50]

https://codereview.chromium.org/1669453003/diff/1/sql/recovery_unittest.cc
File sql/recovery_unittest.cc (right):

https://codereview.chromium.org/1669453003/diff/1/sql/recovery_unittest.cc#ne...
sql/recovery_unittest.cc:176: #if !defined(USE_SYSTEM_SQLITE)
On 2016/02/04 20:24:19, Ryan Hamilton wrote:
> Can you remove this now since you're not using the virtual table?

AutoRecoverTable() is itself implemented in terms of the virtual table, which is
only present when we compile the version of SQLite included with Chromium.

My near-term goal is to remove the USE_SYSTEM_SQLITE ifdefs.  Rather than
elaborate here, I logged it in a bug http://crbug.com/584407 .  Right now I'm
just landing little cleanups which improve things without regard to that.

[Scott Hess - ex-Googler, 2016-02-04 20:47:57]

The CQ bit was checked by shess@chromium.org

[commit-bot: I haz the power, 2016-02-04 20:48:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1669453003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1669453003/1

[commit-bot: I haz the power, 2016-02-04 20:56:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-04 20:57:43]

Description was changed from

==========
[sql] Clean up sql::Recovery unit test.

Test baseline sql::Recovery::Rollback() operation.  Change
RecoveryCallback() to use AutoRecoverTable() rather than manual virtual
table setup.  Inject an artificial error to provoke callback in
RecoverCorruptTable rather than calling manually.

BUG=none
==========

to

==========
[sql] Clean up sql::Recovery unit test.

Test baseline sql::Recovery::Rollback() operation.  Change
RecoveryCallback() to use AutoRecoverTable() rather than manual virtual
table setup.  Inject an artificial error to provoke callback in
RecoverCorruptTable rather than calling manually.

BUG=none

Committed: https://crrev.com/6ac39546b2c45d8a9b06ba08a19811f5f224934c
Cr-Commit-Position: refs/heads/master@{#373613}
==========

[commit-bot: I haz the power, 2016-02-04 20:57:44]

Patchset 1 (id:??) landed as
https://crrev.com/6ac39546b2c45d8a9b06ba08a19811f5f224934c
Cr-Commit-Position: refs/heads/master@{#373613}