Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: chrome/test/chromedriver/chrome/stub_web_view.cc

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove DEPS modifications. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/stub_web_view.cc
diff --git a/chrome/test/chromedriver/chrome/stub_web_view.cc b/chrome/test/chromedriver/chrome/stub_web_view.cc
index 0af2fabf8399a9ea4098684873250c09b84459be..4d5be50bc82dcdda796f58a7b666890544d3bcc3 100644
--- a/chrome/test/chromedriver/chrome/stub_web_view.cc
+++ b/chrome/test/chromedriver/chrome/stub_web_view.cc
@@ -32,7 +32,7 @@ Status StubWebView::GetUrl(std::string* url) {
return Status(kOk);
}
-Status StubWebView::Load(const std::string& url) {
+Status StubWebView::Load(const std::string& url, const Timeout* timeout) {
return Status(kOk);
}
@@ -107,12 +107,13 @@ Status StubWebView::DeleteCookie(const std::string& name,
}
Status StubWebView::WaitForPendingNavigations(const std::string& frame_id,
- const base::TimeDelta& timeout,
+ const Timeout& timeout,
bool stop_load_on_timeout) {
return Status(kOk);
}
Status StubWebView::IsPendingNavigation(const std::string& frame_id,
+ const Timeout* timeout,
bool* is_pending) {
return Status(kOk);
}

Powered by Google App Engine
This is Rietveld 408576698