Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: chrome/test/chromedriver/performance_logger_unittest.cc

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pure virtual Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/performance_logger.cc ('k') | chrome/test/chromedriver/session_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/performance_logger_unittest.cc
diff --git a/chrome/test/chromedriver/performance_logger_unittest.cc b/chrome/test/chromedriver/performance_logger_unittest.cc
index 967bf224246d71a6cd93e7872797991744792b5a..cca0ad3cbd8d8de77d4349b1bac58848e3670e3b 100644
--- a/chrome/test/chromedriver/performance_logger_unittest.cc
+++ b/chrome/test/chromedriver/performance_logger_unittest.cc
@@ -260,7 +260,7 @@ class FakeBrowserwideClient : public FakeDevToolsClient {
// Overridden from DevToolsClient:
Status HandleEventsUntil(const ConditionalFunc& conditional_func,
- const base::TimeDelta& timeout) override {
+ const Timeout& timeout) override {
TriggerEvent("Tracing.tracingComplete");
events_handled_ = true;
return Status(kOk);
« no previous file with comments | « chrome/test/chromedriver/performance_logger.cc ('k') | chrome/test/chromedriver/session_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698