Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6922)

Unified Diff: chrome/test/chromedriver/chrome/stub_web_view.cc

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: pure virtual Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/stub_web_view.h ('k') | chrome/test/chromedriver/chrome/web_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/stub_web_view.cc
diff --git a/chrome/test/chromedriver/chrome/stub_web_view.cc b/chrome/test/chromedriver/chrome/stub_web_view.cc
index f0ab4c84e1a908887902c00b84588feb012dfeb0..df7b3f5e0561e08c9f65dc23cb60f3e82090bd77 100644
--- a/chrome/test/chromedriver/chrome/stub_web_view.cc
+++ b/chrome/test/chromedriver/chrome/stub_web_view.cc
@@ -32,7 +32,7 @@ Status StubWebView::GetUrl(std::string* url) {
return Status(kOk);
}
-Status StubWebView::Load(const std::string& url) {
+Status StubWebView::Load(const std::string& url, const Timeout* timeout) {
return Status(kOk);
}
@@ -108,12 +108,13 @@ Status StubWebView::DeleteCookie(const std::string& name,
}
Status StubWebView::WaitForPendingNavigations(const std::string& frame_id,
- const base::TimeDelta& timeout,
+ const Timeout& timeout,
bool stop_load_on_timeout) {
return Status(kOk);
}
Status StubWebView::IsPendingNavigation(const std::string& frame_id,
+ const Timeout* timeout,
bool* is_pending) {
return Status(kOk);
}
« no previous file with comments | « chrome/test/chromedriver/chrome/stub_web_view.h ('k') | chrome/test/chromedriver/chrome/web_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698