Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/test/chromedriver/util_unittest.cc

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/util_unittest.cc
diff --git a/chrome/test/chromedriver/util_unittest.cc b/chrome/test/chromedriver/util_unittest.cc
index d68dd36a6bcebad9d900f875641eb483583812b3..edeabf3f04d1b57fdfe0d06bd66232a42deb3c25 100644
--- a/chrome/test/chromedriver/util_unittest.cc
+++ b/chrome/test/chromedriver/util_unittest.cc
@@ -12,6 +12,8 @@
#include "chrome/test/chromedriver/util.h"
#include "testing/gtest/include/gtest/gtest.h"
+using base::TimeDelta;
+
TEST(UnzipSoleFile, Entry) {
base::ScopedTempDir temp_dir;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
@@ -48,3 +50,46 @@ TEST(UnzipSoleFile, Archive) {
ASSERT_TRUE(base::ReadFileToString(file, &contents));
ASSERT_STREQ("COW\n", contents.c_str());
}
+
+TEST(TimeoutTest, Basics) {
+ Timeout timeout;
+ EXPECT_FALSE(timeout.is_set());
+ EXPECT_FALSE(timeout.IsExpired());
+ EXPECT_EQ(TimeDelta::Max(), timeout.GetDuration());
+ EXPECT_EQ(TimeDelta::Max(), timeout.GetRemainingTime());
+
+ timeout.SetDuration(TimeDelta());
+ EXPECT_TRUE(timeout.is_set());
+ EXPECT_TRUE(timeout.IsExpired());
+ EXPECT_EQ(TimeDelta(), timeout.GetDuration());
+ EXPECT_GE(TimeDelta(), timeout.GetRemainingTime());
+}
+
+TEST(TimeoutTest, Derive) {
+ Timeout timeout(TimeDelta::FromMinutes(5));
+ EXPECT_TRUE(timeout.is_set());
+ EXPECT_FALSE(timeout.IsExpired());
+ EXPECT_EQ(TimeDelta::FromMinutes(5), timeout.GetDuration());
+ EXPECT_GE(TimeDelta::FromMinutes(5), timeout.GetRemainingTime());
+
+ Timeout small = Timeout(TimeDelta::FromSeconds(10), &timeout);
+ EXPECT_TRUE(small.is_set());
+ EXPECT_FALSE(small.IsExpired());
+ EXPECT_EQ(TimeDelta::FromSeconds(10), small.GetDuration());
+
+ Timeout large = Timeout(TimeDelta::FromMinutes(30), &timeout);
+ EXPECT_TRUE(large.is_set());
+ EXPECT_FALSE(large.IsExpired());
+ EXPECT_GE(timeout.GetDuration(), large.GetDuration());
+}
+
+TEST(TimeoutTest, DeriveExpired) {
+ Timeout timeout((TimeDelta()));
+ EXPECT_TRUE(timeout.is_set());
+ EXPECT_TRUE(timeout.IsExpired());
+
+ Timeout derived = Timeout(TimeDelta::FromSeconds(10), &timeout);
+ EXPECT_TRUE(derived.is_set());
+ EXPECT_TRUE(derived.IsExpired());
+ EXPECT_GE(TimeDelta(), derived.GetDuration());
+}

Powered by Google App Engine
This is Rietveld 408576698