Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2339)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/chromedriver/session_commands.cc

Issue 1669453002: [chromedriver] Apply page load timeout to slow cross-process navigations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/test/chromedriver/chrome/devtools_client.cc ('K') | « chrome/test/chromedriver/performance_logger_unittest.cc ('k') | chrome/test/chromedriver/test/run_py_tests.py » ('j') | chrome/test/chromedriver/util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/session_commands.cc
diff --git a/chrome/test/chromedriver/session_commands.cc b/chrome/test/chromedriver/session_commands.cc
index c47ef7226a5a4e520904d13c1927d78635f43fc0..df520a4b0b894cdff963a952c7cee8aeb5dae8f6 100644
--- a/chrome/test/chromedriver/session_commands.cc
+++ b/chrome/test/chromedriver/session_commands.cc
@@ -469,7 +469,7 @@ Status ExecuteIsLoading(
bool is_pending;
status = web_view->IsPendingNavigation(
- session->GetCurrentFrameId(), &is_pending);
+ session->GetCurrentFrameId(), nullptr, &is_pending);
if (status.IsError())
return status;
value->reset(new base::FundamentalValue(is_pending));
« chrome/test/chromedriver/chrome/devtools_client.cc ('K') | « chrome/test/chromedriver/performance_logger_unittest.cc ('k') | chrome/test/chromedriver/test/run_py_tests.py » ('j') | chrome/test/chromedriver/util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698