Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: src/IceELFSection.h

Issue 1669443002: Subzero. Uses fixups to calculate addend to relocations. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Addresses comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceELFSection.h
diff --git a/src/IceELFSection.h b/src/IceELFSection.h
index 24d814b6a52540c2eb6211cea3e2d71c92d9b94f..67e8483cd5be52f630531357e5b1fccd6695c64a 100644
--- a/src/IceELFSection.h
+++ b/src/IceELFSection.h
@@ -367,13 +367,6 @@ void ELFRelocationSection::writeData(const GlobalContext &Ctx, ELFStreamer &Str,
Rela.r_offset = Fixup.position();
Rela.setSymbolAndType(Symbol->getNumber(), Fixup.kind());
Rela.r_addend = Fixup.offset();
- if (Fixup.kind() == llvm::ELF::R_X86_64_PC32) {
- // In ELF64, PC-relative relocations' addends need to account for the
- // immediate size. For now, this is always 4 (because x86-64 sandboxed
- // is the only ELF64 target currently implemented.)
- constexpr int32_t RelocImmediateSize = 4;
- Rela.r_addend -= RelocImmediateSize;
- }
Str.writeAddrOrOffset<IsELF64>(Rela.r_offset);
Str.writeELFXword<IsELF64>(Rela.r_info);
Str.writeELFXword<IsELF64>(Rela.r_addend);

Powered by Google App Engine
This is Rietveld 408576698