More aggressively fail when associating an existing element model with an AST (issue 25678)

More aggressively fail when associating an existing element model with an AST (issue 25678).

The problem we're seeing is that mismatches between the element model and the AST are causing exceptions to be thrown that are not being handled by the normal exception handling in AnalysisTask. This causes the exception to be converted into an AnalysisException, which will cause the AST structure to be marked as being in ERROR, and it will be re-computed later after a change invalidates it.

This also causes the exception to be thrown more frequently to prevent mismatches from being ignored (and to report the mismatch earlier).

This only checks that every node in the AST has an element associated with it. The next step (in a future CL) is to ensure that the opposite problem doesn't exist (that is, that all elements are associated with a node).

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/ade0e4c5cdb9a3068f5704faf57e8bbf7c43bb96

[Brian Wilkerson, 2016-02-05 18:50:20]

Description was changed from

==========
More agressively fail when associating an existing element model with an AST
(issue 25678)
==========

to

==========
More aggressively fail when associating an existing element model with an AST
(issue 25678).

The problem we're seeing is that mismatches between the element model and the
AST are causing exceptions to be thrown that are not being handled by the normal
exception handling in AnalysisTask. This causes the exception to be converted
into an AnalysisException, which will cause the AST structure to be marked as
being in ERROR, and it will be re-computed later after a change invalidates it.

This also causes the exception to be thrown more frequently to prevent
mismatches from being ignored (and to report the mismatch earlier).

This only checks that every node in the AST has an element associated with it.
The next step (in a future CL) is to ensure that the opposite problem doesn't
exist (that is, that all elements are associated with a node).
==========

[Brian Wilkerson, 2016-02-05 18:50:27]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-02-05 18:57:53]

LGTM

[Brian Wilkerson, 2016-02-05 20:28:52]

Description was changed from

==========
More aggressively fail when associating an existing element model with an AST
(issue 25678).

The problem we're seeing is that mismatches between the element model and the
AST are causing exceptions to be thrown that are not being handled by the normal
exception handling in AnalysisTask. This causes the exception to be converted
into an AnalysisException, which will cause the AST structure to be marked as
being in ERROR, and it will be re-computed later after a change invalidates it.

This also causes the exception to be thrown more frequently to prevent
mismatches from being ignored (and to report the mismatch earlier).

This only checks that every node in the AST has an element associated with it.
The next step (in a future CL) is to ensure that the opposite problem doesn't
exist (that is, that all elements are associated with a node).
==========

to

==========
More aggressively fail when associating an existing element model with an AST
(issue 25678).

The problem we're seeing is that mismatches between the element model and the
AST are causing exceptions to be thrown that are not being handled by the normal
exception handling in AnalysisTask. This causes the exception to be converted
into an AnalysisException, which will cause the AST structure to be marked as
being in ERROR, and it will be re-computed later after a change invalidates it.

This also causes the exception to be thrown more frequently to prevent
mismatches from being ignored (and to report the mismatch earlier).

This only checks that every node in the AST has an element associated with it.
The next step (in a future CL) is to ensure that the opposite problem doesn't
exist (that is, that all elements are associated with a node).

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ade0e4c5cdb9a3068f5704faf57e8bbf7c43bb96
==========

[Brian Wilkerson, 2016-02-05 20:28:54]

Committed patchset #1 (id:1) manually as
ade0e4c5cdb9a3068f5704faf57e8bbf7c43bb96 (presubmit successful).