Error reporting for SVGAngle

Error reporting for SVGAngle

Refactor the local helepr stringToAngleType(...) to only advance past
complete matches (of units).

BUG=231612
Committed: https://crrev.com/b16f535182ea1960aed13848a60e0226f8d24eb6
Cr-Commit-Position: refs/heads/master@{#373888}

[fs, 2016-02-05 18:52:34]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org, schenney@chromium.org

[Stephen Chennney, 2016-02-05 19:05:23]

I think the error messaging is good. We could go further and report distinct
errors for bad number versus bad angle type, but I think that's overkill; a
developer could locate the problem given the simple message.

What is the new test expectation on some platform?

[fs, 2016-02-05 19:17:38]

On 2016/02/05 at 19:05:23, schenney wrote:
> I think the error messaging is good. We could go further and report distinct
errors for bad number versus bad angle type, but I think that's overkill; a
developer could locate the problem given the simple message.

There was another factor that caused me to be a bit "lazy" here for now - I
intend to give SVGAngle the same treatment as SVGLength (i.e use
CSSPrimitiveValues/the CSSParser), so fidelity would be lost (until the
CSSParser can produce something more precise.)

> What is the new test expectation on some platform?

https://storage.googleapis.com/chromium-layout-test-archives/mac_chromium_rel...

(same as the other one - not a pretty diff - scroll all the way down for the new
messages)

[Stephen Chennney, 2016-02-05 19:44:29]

On 2016/02/05 19:17:38, fs wrote:
> On 2016/02/05 at 19:05:23, schenney wrote:
> > I think the error messaging is good. We could go further and report distinct
> errors for bad number versus bad angle type, but I think that's overkill; a
> developer could locate the problem given the simple message.
> 
> There was another factor that caused me to be a bit "lazy" here for now - I
> intend to give SVGAngle the same treatment as SVGLength (i.e use
> CSSPrimitiveValues/the CSSParser), so fidelity would be lost (until the
> CSSParser can produce something more precise.)
> 
> > What is the new test expectation on some platform?
> 
>
https://storage.googleapis.com/chromium-layout-test-archives/mac_chromium_rel...
> 
> (same as the other one - not a pretty diff - scroll all the way down for the
new
> messages)

Sorry for not remembering the try bot archives.

LGTM

[fs, 2016-02-05 19:56:13]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2016-02-05 19:58:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1669333002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1669333002/1

[commit-bot: I haz the power, 2016-02-05 20:09:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-05 20:24:15]

Description was changed from

==========
Error reporting for SVGAngle

Refactor the local helepr stringToAngleType(...) to only advance past
complete matches (of units).

BUG=231612
==========

to

==========
Error reporting for SVGAngle

Refactor the local helepr stringToAngleType(...) to only advance past
complete matches (of units).

BUG=231612

Committed: https://crrev.com/b16f535182ea1960aed13848a60e0226f8d24eb6
Cr-Commit-Position: refs/heads/master@{#373888}
==========

[commit-bot: I haz the power, 2016-02-05 20:24:17]

Patchset 1 (id:??) landed as
https://crrev.com/b16f535182ea1960aed13848a60e0226f8d24eb6
Cr-Commit-Position: refs/heads/master@{#373888}