Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1669303002: Tests for deopt from finally block. (Closed)

Created:
4 years, 10 months ago by Jarin
Modified:
4 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Tests for deopt from finally block. Committed: https://crrev.com/1b33ffa49a10335268126177562473824d0bca26 Cr-Commit-Position: refs/heads/master@{#33942}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -0 lines) Patch
A test/mjsunit/compiler/try-finally-deopt.js View 1 chunk +249 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please?
4 years, 10 months ago (2016-02-05 15:47:18 UTC) #2
Michael Starzinger
LGTM. Nice!
4 years, 10 months ago (2016-02-08 15:44:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669303002/1
4 years, 10 months ago (2016-02-12 11:28:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 12:17:01 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 12:17:42 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1b33ffa49a10335268126177562473824d0bca26
Cr-Commit-Position: refs/heads/master@{#33942}

Powered by Google App Engine
This is Rietveld 408576698