Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Side by Side Diff: content/browser/renderer_host/input/touch_event_queue_unittest.cc

Issue 166923002: Add touch scrolling modes experimental flags (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/logging.h" 6 #include "base/logging.h"
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "content/browser/renderer_host/input/timeout_monitor.h" 9 #include "content/browser/renderer_host/input/timeout_monitor.h"
10 #include "content/browser/renderer_host/input/touch_event_queue.h" 10 #include "content/browser/renderer_host/input/touch_event_queue.h"
(...skipping 10 matching lines...) Expand all
21 namespace { 21 namespace {
22 const size_t kDefaultTouchTimeoutDelayMs = 10; 22 const size_t kDefaultTouchTimeoutDelayMs = 10;
23 } 23 }
24 24
25 class TouchEventQueueTest : public testing::Test, 25 class TouchEventQueueTest : public testing::Test,
26 public TouchEventQueueClient { 26 public TouchEventQueueClient {
27 public: 27 public:
28 TouchEventQueueTest() 28 TouchEventQueueTest()
29 : sent_event_count_(0), 29 : sent_event_count_(0),
30 acked_event_count_(0), 30 acked_event_count_(0),
31 last_acked_event_state_(INPUT_EVENT_ACK_STATE_UNKNOWN) {} 31 last_acked_event_state_(INPUT_EVENT_ACK_STATE_UNKNOWN),
32 touch_scrolling_mode_(TouchEventQueue::TOUCH_SCROLLING_MODE_DEFAULT),
33 slop_length_dips_(0) {}
32 34
33 virtual ~TouchEventQueueTest() {} 35 virtual ~TouchEventQueueTest() {}
34 36
35 // testing::Test 37 // testing::Test
36 virtual void SetUp() OVERRIDE { 38 virtual void SetUp() OVERRIDE {
37 queue_.reset(new TouchEventQueue(this, 0)); 39 ResetQueueWithParameters(touch_scrolling_mode_, slop_length_dips_);
38 queue_->OnHasTouchEventHandlers(true); 40 }
41
42 virtual void SetTouchScrollingMode(TouchEventQueue::TouchScrollingMode mode) {
43 touch_scrolling_mode_ = mode;
44 ResetQueueWithParameters(touch_scrolling_mode_, slop_length_dips_);
39 } 45 }
40 46
41 virtual void TearDown() OVERRIDE { 47 virtual void TearDown() OVERRIDE {
42 queue_.reset(); 48 queue_.reset();
43 } 49 }
44 50
45 // TouchEventQueueClient 51 // TouchEventQueueClient
46 virtual void SendTouchEventImmediately( 52 virtual void SendTouchEventImmediately(
47 const TouchEventWithLatencyInfo& event) OVERRIDE { 53 const TouchEventWithLatencyInfo& event) OVERRIDE {
48 ++sent_event_count_; 54 ++sent_event_count_;
(...skipping 22 matching lines...) Expand all
71 } 77 }
72 } 78 }
73 79
74 protected: 80 protected:
75 81
76 void SetUpForTimeoutTesting(size_t timeout_delay_ms) { 82 void SetUpForTimeoutTesting(size_t timeout_delay_ms) {
77 queue_->SetAckTimeoutEnabled(true, timeout_delay_ms); 83 queue_->SetAckTimeoutEnabled(true, timeout_delay_ms);
78 } 84 }
79 85
80 void SetUpForTouchMoveSlopTesting(double slop_length_dips) { 86 void SetUpForTouchMoveSlopTesting(double slop_length_dips) {
81 queue_.reset(new TouchEventQueue(this, slop_length_dips)); 87 slop_length_dips_ = slop_length_dips;
82 queue_->OnHasTouchEventHandlers(true); 88 ResetQueueWithParameters(touch_scrolling_mode_, slop_length_dips_);
83 } 89 }
84 90
85 void SendTouchEvent(const WebTouchEvent& event) { 91 void SendTouchEvent(const WebTouchEvent& event) {
86 queue_->QueueEvent(TouchEventWithLatencyInfo(event, ui::LatencyInfo())); 92 queue_->QueueEvent(TouchEventWithLatencyInfo(event, ui::LatencyInfo()));
87 } 93 }
88 94
89 void SendGestureEvent(WebInputEvent::Type type) { 95 void SendGestureEvent(WebInputEvent::Type type) {
90 WebGestureEvent event; 96 WebGestureEvent event;
91 event.type = type; 97 event.type = type;
92 queue_->OnGestureScrollEvent( 98 queue_->OnGestureScrollEvent(
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 InputEventAckState acked_event_state() const { 184 InputEventAckState acked_event_state() const {
179 return last_acked_event_state_; 185 return last_acked_event_state_;
180 } 186 }
181 187
182 private: 188 private:
183 void SendTouchEvent() { 189 void SendTouchEvent() {
184 SendTouchEvent(touch_event_); 190 SendTouchEvent(touch_event_);
185 touch_event_.ResetPoints(); 191 touch_event_.ResetPoints();
186 } 192 }
187 193
194 void ResetQueueWithParameters(TouchEventQueue::TouchScrollingMode mode,
195 double slop_length_dips) {
196 queue_.reset(new TouchEventQueue(this, mode, slop_length_dips));
197 queue_->OnHasTouchEventHandlers(true);
198 }
199
188 scoped_ptr<TouchEventQueue> queue_; 200 scoped_ptr<TouchEventQueue> queue_;
189 size_t sent_event_count_; 201 size_t sent_event_count_;
190 size_t acked_event_count_; 202 size_t acked_event_count_;
191 WebTouchEvent last_sent_event_; 203 WebTouchEvent last_sent_event_;
192 WebTouchEvent last_acked_event_; 204 WebTouchEvent last_acked_event_;
193 InputEventAckState last_acked_event_state_; 205 InputEventAckState last_acked_event_state_;
194 SyntheticWebTouchEvent touch_event_; 206 SyntheticWebTouchEvent touch_event_;
195 scoped_ptr<WebTouchEvent> followup_touch_event_; 207 scoped_ptr<WebTouchEvent> followup_touch_event_;
196 scoped_ptr<WebGestureEvent> followup_gesture_event_; 208 scoped_ptr<WebGestureEvent> followup_gesture_event_;
197 scoped_ptr<InputEventAckState> sync_ack_result_; 209 scoped_ptr<InputEventAckState> sync_ack_result_;
210 double slop_length_dips_;
211 TouchEventQueue::TouchScrollingMode touch_scrolling_mode_;
198 base::MessageLoopForUI message_loop_; 212 base::MessageLoopForUI message_loop_;
199 }; 213 };
200 214
201 215
202 // Tests that touch-events are queued properly. 216 // Tests that touch-events are queued properly.
203 TEST_F(TouchEventQueueTest, Basic) { 217 TEST_F(TouchEventQueueTest, Basic) {
204 PressTouchPoint(1, 1); 218 PressTouchPoint(1, 1);
205 EXPECT_EQ(1U, queued_event_count()); 219 EXPECT_EQ(1U, queued_event_count());
206 EXPECT_EQ(1U, GetAndResetSentEventCount()); 220 EXPECT_EQ(1U, GetAndResetSentEventCount());
207 221
(...skipping 1179 matching lines...) Expand 10 before | Expand all | Expand 10 after
1387 EXPECT_EQ(1U, GetAndResetAckedEventCount()); 1401 EXPECT_EQ(1U, GetAndResetAckedEventCount());
1388 1402
1389 // TouchMove's should not should be suppressed, even with the original 1403 // TouchMove's should not should be suppressed, even with the original
1390 // unmoved pointer. 1404 // unmoved pointer.
1391 MoveTouchPoint(0, 0, 0); 1405 MoveTouchPoint(0, 0, 0);
1392 EXPECT_EQ(1U, queued_event_count()); 1406 EXPECT_EQ(1U, queued_event_count());
1393 EXPECT_EQ(1U, GetAndResetSentEventCount()); 1407 EXPECT_EQ(1U, GetAndResetSentEventCount());
1394 EXPECT_EQ(0U, GetAndResetAckedEventCount()); 1408 EXPECT_EQ(0U, GetAndResetAckedEventCount());
1395 } 1409 }
1396 1410
1411 //TEST_F(TouchEventQueueTest, SyncTouchMoveDoesntCancelTouchOnScroll) {
1412 // SetTouchScrollingMode(TouchEventQueue::TOUCH_SCROLLING_MODE_SYNC_TOUCHMOVE);
1413 // // Queue a TouchStart.
1414 // PressTouchPoint(0, 1);
1415 // EXPECT_EQ(1U, GetAndResetSentEventCount());
1416 // SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
1417 // EXPECT_EQ(1U, GetAndResetAckedEventCount());
1418 //
1419 // MoveTouchPoint(0, 20, 5);
1420 // EXPECT_EQ(1U, queued_event_count());
1421 // EXPECT_EQ(1U, GetAndResetSentEventCount());
1422 //
1423 // // GestureScrollBegin doesn't insert a synthetic TouchCancel.
1424 // WebGestureEvent followup_scroll;
1425 // followup_scroll.type = WebInputEvent::GestureScrollBegin;
1426 // SetFollowupEvent(followup_scroll);
1427 // SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
1428 // EXPECT_EQ(0U, GetAndResetSentEventCount());
1429 // EXPECT_EQ(1U, GetAndResetAckedEventCount());
1430 // EXPECT_EQ(0U, queued_event_count());
1431 //}
1432 //
1433 //TEST_F(TouchEventQueueTest, TouchAbsorption) {
1434 // SetTouchScrollingMode(
1435 // TouchEventQueue::TOUCH_SCROLLING_MODE_ABSORB_TOUCHMOVE);
1436 // // Queue a TouchStart.
1437 // PressTouchPoint(0, 1);
1438 // EXPECT_EQ(1U, GetAndResetSentEventCount());
1439 // SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
1440 // EXPECT_EQ(1U, GetAndResetAckedEventCount());
1441 //
1442 // for (int i = 0; i < 3; ++i) {
1443 // SendGestureEventACK(WebInputEvent::GestureScrollUpdate,
1444 // INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
1445 //
1446 // MoveTouchPoint(0, 20, 5);
1447 // SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
1448 // EXPECT_EQ(0U, queued_event_count());
1449 // EXPECT_EQ(1U, GetAndResetSentEventCount());
1450 //
1451 // // Consuming a scroll event prevents the next touch moves from being
1452 // // dispatched.
1453 // SendGestureEventACK(WebInputEvent::GestureScrollUpdate,
1454 // INPUT_EVENT_ACK_STATE_CONSUMED);
1455 // MoveTouchPoint(0, 20, 5);
1456 // SendTouchEventACK(INPUT_EVENT_ACK_STATE_NOT_CONSUMED);
1457 // EXPECT_EQ(0U, queued_event_count());
1458 // EXPECT_EQ(0U, GetAndResetSentEventCount());
1459 // }
1460 //}
1461
1397 } // namespace content 1462 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698