Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1669213003: [crankshaft] Replace stub cache harvesting with a bit of type propagation (Closed)

Created:
4 years, 10 months ago by Jakob Kummerow
Modified:
4 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Replace stub cache harvesting with a bit of type propagation Harvesting maps from the stub cache for megamorphic ICs is both slow (linear in the size of the stub cache) and imprecise (as it finds all maps that have a cached handler for the given property name). In the canonical megamorphic situation, this type feedback is useless anyway. The interesting case is when we can filter it down to a single map; however in these cases it is often possible to derive this map just by looking at the HGraph, which is both faster and more reliable. Committed: https://crrev.com/5aa2cb3bccbdf339827b3768b1a8f80338b773c7 Cr-Commit-Position: refs/heads/master@{#33998}

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : fixes rebase #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -11 lines) Patch
M src/crankshaft/hydrogen.cc View 1 2 3 4 chunks +40 lines, -10 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api-fast-accessor-builder.cc View 1 2 5 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Jakob Kummerow
PTAL.
4 years, 10 months ago (2016-02-10 12:46:21 UTC) #2
Toon Verwaest
lgtm. Thanks for getting rid of this stub-cache abuse. The feedback is a bit brittle, ...
4 years, 10 months ago (2016-02-12 14:00:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669213003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669213003/40001
4 years, 10 months ago (2016-02-12 14:04:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/13681)
4 years, 10 months ago (2016-02-12 15:03:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1669213003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1669213003/60001
4 years, 10 months ago (2016-02-15 14:57:36 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-15 15:21:37 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 15:22:07 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5aa2cb3bccbdf339827b3768b1a8f80338b773c7
Cr-Commit-Position: refs/heads/master@{#33998}

Powered by Google App Engine
This is Rietveld 408576698