Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5137)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extension_action.cc

Issue 1669163002: [Extensions] Allow extensions to set a rectangular icon for the extension action (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.cc ('k') | chrome/test/data/extensions/api_test/browser_action/rect_icon/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_action.cc
diff --git a/chrome/browser/extensions/extension_action.cc b/chrome/browser/extensions/extension_action.cc
index 05b7d86857f5a9d6821800280505677c66bf798a..4559fe70da00b5cd992daf92e56a1de9f8b7b7c7 100644
--- a/chrome/browser/extensions/extension_action.cc
+++ b/chrome/browser/extensions/extension_action.cc
@@ -150,8 +150,7 @@ bool ExtensionAction::ParseIconFromCanvasDictionary(
// Chrome helpfully scales the provided icon(s), but let's not go overboard.
const int kActionIconMaxSize = 10 * extension_misc::EXTENSION_ICON_ACTION;
- if (bitmap.drawsNothing() || bitmap.width() != bitmap.height() ||
- bitmap.width() > kActionIconMaxSize) {
+ if (bitmap.drawsNothing() || bitmap.width() > kActionIconMaxSize) {
lazyboy 2016/02/05 02:15:57 nit: remove {}
Devlin 2016/02/05 20:45:18 Done.
continue;
}
« no previous file with comments | « chrome/browser/extensions/api/extension_action/extension_action_api.cc ('k') | chrome/test/data/extensions/api_test/browser_action/rect_icon/background.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698