[Extensions] Allow extensions to set a rectangular icon for the extension action

chrome/browser/extensions/extension_action.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_action.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/base64.h"
@@ skipping 132 matching lines @@
       continue;
     }
     base::PickleIterator pickle_iter(pickle);
     SkBitmap bitmap;
     if (!IPC::ReadParam(&pickle, &pickle_iter, &bitmap))
       return false;
     CHECK(!bitmap.isNull());
 
     // Chrome helpfully scales the provided icon(s), but let's not go overboard.
     const int kActionIconMaxSize = 10 * extension_misc::EXTENSION_ICON_ACTION;
-    if (bitmap.drawsNothing() || bitmap.width() != bitmap.height() ||
-        bitmap.width() > kActionIconMaxSize) {
+    if (bitmap.drawsNothing() || bitmap.width() > kActionIconMaxSize) {

[lazyboy, 2016/02/05 02:15:57]

nit: remove {}

[Devlin, 2016/02/05 20:45:18]

Done.

       continue;
     }
 
     float scale =
         static_cast<float>(bitmap.width()) / ExtensionAction::ActionIconSize();
     icon->AddRepresentation(gfx::ImageSkiaRep(bitmap, scale));
   }
   return true;
 }
 
@@ skipping 163 matching lines @@
   // If there is a default icon, the icon width will be set depending on our
   // action type.
   if (default_icon_)
     return ActionIconSize();
 
   // If no icon has been set and there is no default icon, we need favicon
   // width.
   return ui::ResourceBundle::GetSharedInstance().GetImageNamed(
           IDR_EXTENSIONS_FAVICON).Width();
 }