[Extensions] Allow extensions to set a rectangular icon for the extension action

[Extensions] Allow extensions to set a rectangular icon for the extension action

Support rectangular icon images for the extension actions. This regressed in
revision 52969d7388642a56447da090bf577974a6bf562f. Fix, and add a test.

BUG=582924
Committed: https://crrev.com/e2a93e361c49b55cd3a2d750e494389c39f489b5
Cr-Commit-Position: refs/heads/master@{#373904}

[Devlin, 2016-02-05 01:28:50]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-02-05 01:29:05]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-02-05 01:29:05]

Istiaque, mind taking a quick look?

[lazyboy, 2016-02-05 02:15:58]

lgtm

https://codereview.chromium.org/1669163002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_action.cc (right):

https://codereview.chromium.org/1669163002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_action.cc:153: if (bitmap.drawsNothing() ||
bitmap.width() > kActionIconMaxSize) {
nit: remove {}

[Devlin, 2016-02-05 20:45:18]

https://codereview.chromium.org/1669163002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_action.cc (right):

https://codereview.chromium.org/1669163002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_action.cc:153: if (bitmap.drawsNothing() ||
bitmap.width() > kActionIconMaxSize) {
On 2016/02/05 02:15:57, lazyboy wrote:
> nit: remove {}

Done.

[Devlin, 2016-02-05 20:45:24]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-02-05 20:45:24]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/1669163002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-02-05 20:47:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1669163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1669163002/40001

[commit-bot: I haz the power, 2016-02-05 20:55:50]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-02-05 20:59:42]

Description was changed from

==========
[Extensions] Allow extensions to set a rectangular icon for the extension action

Support rectangular icon images for the extension actions. This regressed in
revision 52969d7388642a56447da090bf577974a6bf562f. Fix, and add a test.

BUG=582924
==========

to

==========
[Extensions] Allow extensions to set a rectangular icon for the extension action

Support rectangular icon images for the extension actions. This regressed in
revision 52969d7388642a56447da090bf577974a6bf562f. Fix, and add a test.

BUG=582924

Committed: https://crrev.com/e2a93e361c49b55cd3a2d750e494389c39f489b5
Cr-Commit-Position: refs/heads/master@{#373904}
==========

[commit-bot: I haz the power, 2016-02-05 20:59:43]

Patchset 2 (id:??) landed as
https://crrev.com/e2a93e361c49b55cd3a2d750e494389c39f489b5
Cr-Commit-Position: refs/heads/master@{#373904}