Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: Source/core/page/DOMWindow.idl

Issue 16691003: Remove Constructor attributes on DOMWindow because of [EnabledAtRuntime] (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update TestExpectations Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/DOMWindow.idl
diff --git a/Source/core/page/DOMWindow.idl b/Source/core/page/DOMWindow.idl
index 09224c2f9e844ef120355f2e81792a7e89e63021..87238f4dbd1fc83fecd8894dd24362a547ef0537 100644
--- a/Source/core/page/DOMWindow.idl
+++ b/Source/core/page/DOMWindow.idl
@@ -298,33 +298,17 @@
attribute IDBRequestConstructor webkitIDBRequest;
attribute IDBTransactionConstructor webkitIDBTransaction;
- // Constructors enabled at runtime but whose interface does not have EnabledAtRuntime
- // extended attribute.
- // FIXME: Remove these.
- [EnabledAtRuntime=media] attribute MediaErrorConstructor MediaError;
- [EnabledAtRuntime=media] attribute TimeRangesConstructor TimeRanges;
- [EnabledAtRuntime=media] attribute HTMLSourceElementConstructor HTMLSourceElement;
- [EnabledAtRuntime=media] attribute MediaControllerConstructor MediaController;
- [EnabledAtRuntime=deviceMotion] attribute DeviceMotionEventConstructor DeviceMotionEvent;
- [EnabledAtRuntime=touch] attribute TouchConstructor Touch;
- [EnabledAtRuntime=touch] attribute TouchEventConstructor TouchEvent;
- [EnabledAtRuntime=touch] attribute TouchListConstructor TouchList;
- [EnabledAtRuntime=webMIDI] attribute MIDIConnectionEventConstructor MIDIConnectionEvent;
- [EnabledAtRuntime=webMIDI] attribute MIDIMessageEventConstructor MIDIMessageEvent;
+ // Constructors whose name does not match the interface name.
+ // FIXME: Remove these once [ImplementedAs] is used and once constructor names match interface names.
[EnabledAtRuntime=mediaStream] attribute MediaStreamConstructor webkitMediaStream;
[Conditional=WEB_AUDIO, EnabledAtRuntime=WebAudio] attribute AudioContextConstructor webkitAudioContext;
[Conditional=WEB_AUDIO, EnabledAtRuntime=WebAudio] attribute OfflineAudioContextConstructor webkitOfflineAudioContext;
[EnabledAtRuntime=peerConnection] attribute RTCPeerConnectionConstructor webkitRTCPeerConnection;
- [EnabledAtRuntime=experimentalContentSecurityPolicyFeatures] attribute SecurityPolicyViolationEventConstructor SecurityPolicyViolationEvent;
- [EnabledAtRuntime] attribute SharedWorkerConstructor SharedWorker; // Usable with the new operator
[EnabledAtRuntime=scriptedSpeech] attribute SpeechGrammarConstructor webkitSpeechGrammar;
[EnabledAtRuntime=scriptedSpeech] attribute SpeechGrammarListConstructor webkitSpeechGrammarList;
[EnabledAtRuntime=scriptedSpeech] attribute SpeechRecognitionConstructor webkitSpeechRecognition;
[EnabledAtRuntime=scriptedSpeech] attribute SpeechRecognitionErrorConstructor webkitSpeechRecognitionError;
[EnabledAtRuntime=scriptedSpeech] attribute SpeechRecognitionEventConstructor webkitSpeechRecognitionEvent;
-
- // Constructors whose name does not match the interface name.
- // FIXME: Remove these once [ImplementedAs] is used and once constructor names match interface names.
attribute ShadowRootConstructor WebKitShadowRoot;
[Conditional=WEB_AUDIO] attribute PannerNodeConstructor webkitAudioPannerNode;

Powered by Google App Engine
This is Rietveld 408576698